[squeak-dev] The Trunk: Protocols-mt.74.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Oct 11 11:44:57 UTC 2020


Marcel Taeumel uploaded a new version of Protocols to project The Trunk:
http://source.squeak.org/trunk/Protocols-mt.74.mcz

==================== Summary ====================

Name: Protocols-mt.74
Author: mt
Time: 11 October 2020, 1:44:56.309652 pm
UUID: 4334a75d-71a3-9540-a840-545153508848
Ancestors: Protocols-mt.73

Refactoring 'Active' variables -- Step 2 of 2. Removes all uses of Active(World|Hand|Event) by replacing those with "self current(World|Hand|Event)" or "Project current world" when required to not add/cement Morphic dependency.

See http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-td5121690.html

=============== Diff against Protocols-mt.73 ===============

Item was changed:
  ----- Method: InstanceBrowser>>offerMenu (in category 'menu commands') -----
  offerMenu
  	"Offer a menu to the user, in response to the hitting of the menu button on the tool pane"
  
  	| aMenu |
  	aMenu := MenuMorph new defaultTarget: self.
+ 	aMenu title: ('Messages of {1}' translated format: {objectViewed nameForViewer}).
- 	aMenu title: 'Messages of ', objectViewed nameForViewer.
  	aMenu addStayUpItem.
+ 	aMenu addTranslatedList: #(
- 	aMenu addList: #(
  		('vocabulary...' 			chooseVocabulary)
  		('what to show...'			offerWhatToShowMenu)
  		-
  		('inst var refs (here)'		setLocalInstVarRefs)
  		('inst var defs (here)'		setLocalInstVarDefs)
  		('class var refs (here)'		setLocalClassVarRefs)
  		-
  
  		('navigate to a sender...' 	navigateToASender)
  		('recent...' 					navigateToRecentMethod)
  		('show methods in current change set'
  									showMethodsInCurrentChangeSet)
  		('show methods with initials...'
  									showMethodsWithInitials)
  		-
  		"('toggle search pane' 		toggleSearch)"
  
  		-
  		-
  		('browse full (b)' 			browseMethodFull)
  		('browse hierarchy (h)'		browseClassHierarchy)
  		('browse protocol (p)'		browseFullProtocol)
  		-
  		('fileOut'					fileOutMessage)
  		('printOut'					printOutMessage)
  		-
  		('senders of... (n)'			browseSendersOfMessages)
  		('implementors of... (m)'		browseMessages)
  		('versions (v)' 				browseVersions)
  		('inheritance (i)'			methodHierarchy)
  		-
  		('references... (r)' 				browseVariableReferences)
  		('assignments... (a)' 				browseVariableAssignments)
  		-
  		('viewer on me'				viewViewee)
  		('inspector on me'			inspectViewee)
  		-
  		('more...'					shiftedYellowButtonActivity)).
+ 	
+ 	^ aMenu popUpInWorld: self currentWorld!
- 
- 	aMenu popUpInWorld: ActiveWorld!

Item was changed:
  ----- Method: Lexicon>>offerMenu (in category 'menu commands') -----
  offerMenu
  	"Offer a menu to the user, in response to the hitting of the menu button on the tool pane"
  
  	| aMenu |
  	aMenu := MenuMorph new defaultTarget: self.
+ 	aMenu addTitle: 'Lexicon' translated.
- 	aMenu addTitle: 'Lexicon'.
  	aMenu addStayUpItem.
+ 	aMenu addTranslatedList: #(
- 	aMenu addList: #(
- 
  		('vocabulary...' 			chooseVocabulary)
  		('what to show...'			offerWhatToShowMenu)
  		-
  		('inst var refs (here)'		setLocalInstVarRefs)
  		('inst var assignments (here)'		setLocalInstVarDefs)
  		('class var refs (here)'		setLocalClassVarRefs)
  		-
- 
  		('navigate to a sender...' 	navigateToASender)
  		('recent...' 					navigateToRecentMethod)
+ 		('show methods in current change set'	showMethodsInCurrentChangeSet)
+ 		('show methods with initials...'	showMethodsWithInitials)
- 		('show methods in current change set'
- 									showMethodsInCurrentChangeSet)
- 		('show methods with initials...'
- 									showMethodsWithInitials)
  		-
  		"('toggle search pane' 		toggleSearch)"
- 
  		-
  		('browse full (b)' 			browseMethodFull)
  		('browse hierarchy (h)'		browseClassHierarchy)
  		('browse protocol (p)'		browseFullProtocol)
  		-
  		('fileOut'					fileOutMessage)
  		('printOut'					printOutMessage)
  		-
  		('senders of... (n)'			browseSendersOfMessages)
  		('implementors of... (m)'		browseMessages)
  		('versions (v)' 				browseVersions)
  		('inheritance (i)'			methodHierarchy)
  		-
  		('references... (r)' 				browseVariableReferences)
  		('assignments... (a)' 				browseVariableAssignments)
  		-
  		('more...'					shiftedYellowButtonActivity)).
+ 	
+ 	^ aMenu popUpInWorld: self currentWorld!
- 
- 	aMenu popUpInWorld: ActiveWorld!

Item was changed:
  ----- Method: Object>>haveFullProtocolBrowsedShowingSelector: (in category '*Protocols') -----
  haveFullProtocolBrowsedShowingSelector: aSelector
  	"Open up a Lexicon on the receiver, having it open up showing aSelector, which may be nil"
+ 	"(2 at 3) haveFullProtocolBrowsed"
  
  	| aBrowser |
+ 	aBrowser := (Smalltalk at: #InstanceBrowser ifAbsent: [^ nil]) new
+ 		useVocabulary: Vocabulary fullVocabulary.
+ 	aBrowser
+ 		openOnObject: self
+ 		inWorld: Project current world
+ 		showingSelector: aSelector!
- 	aBrowser := (Smalltalk at: #InstanceBrowser ifAbsent:[^nil]) new useVocabulary: Vocabulary fullVocabulary.
- 	aBrowser openOnObject: self inWorld: ActiveWorld showingSelector: aSelector
- 
- 	"(2 at 3) haveFullProtocolBrowsed"!



More information about the Squeak-dev mailing list