[squeak-dev] The Trunk: ToolBuilder-Morphic-mt.266.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Oct 11 11:45:56 UTC 2020


Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.266.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-mt.266
Author: mt
Time: 11 October 2020, 1:45:54.939652 pm
UUID: f7d11905-3600-e241-a125-d4355a90ecde
Ancestors: ToolBuilder-Morphic-mt.265

Refactoring 'Active' variables -- Step 2 of 2. Removes all uses of Active(World|Hand|Event) by replacing those with "self current(World|Hand|Event)" or "Project current world" when required to not add/cement Morphic dependency.

See http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-td5121690.html

=============== Diff against ToolBuilder-Morphic-mt.265 ===============

Item was changed:
  ----- Method: ListChooser>>accept (in category 'actions') -----
  accept
  	"if the user submits with no valid entry, make them start over"
  	
  	| choice |
  	self canAccept ifFalse: [
  		self canAdd ifTrue: [^ self add].
  		^ self changed: #textSelection].
  	
  	choice := self selectedItem.
  	
  	self canAdd ifTrue: [
  		"Ask the user whether to add the new item or choose the list selection."
  		(UserDialogBoxMorph
  			confirm: 'You can either choose an existing item or add a new one.\What do you want?' translated withCRs
  			title: 'Choose or Add' translated
  			trueChoice: choice asString
+ 			falseChoice: self searchText asString at: self currentHand position)
- 			falseChoice: self searchText asString at: ActiveHand position)
  				ifNil: ["Cancelled" self result: nil. ^ self]
  				ifNotNil: [:answer |
  					answer ifTrue: [self result: choice] ifFalse: [self result: self searchText asString]]
  		] ifFalse: [self result: choice].
- 		
  	
  	self changed: #close.!



More information about the Squeak-dev mailing list