Hi Tim,


some scattered comments on your changes: It's a great idea to refactor this windowTitle stuff!


Personally, I think it would look nicer if you could leave out the spaces between the brackets, e.g. "Implementors of initialize [987]" instead of "Implementors of initialize [ 987 ]".


Not a regression, but still a bug: Select 42 in some method in a MessageTrace and browse senders -> Error: Instances of SmallInteger are not indexable from #findAgainNow. Is this related to your changes?


> Possibly better to do asOrderedCollection sort ?


Sounds reasonable.

> Now, about that improvement to the Shout stuff...

Your ideas sound interesting. We have collected so many ideas on what Shout/attributes could do else (ShoutAttribute<http://forum.world.st/Changeset-ShoutAttribute-amp-semi-styling-td5106776.html>, highlight searched text, and here are some other rough ideas: highlight all occurrences of the currently selected word/selector as you may know it from VS Code; automatically style hyperlinks with a TextURL (ask Tom Beckmann for more details on this idea) or class names with a TextLink; a text attribute that adds a tooltip to a certain subtext; allow to browse a word by Ctrl + clicking it, probably again via a text attribute; ...). Maybe we should finally split up the TextAttribute hierarchy into two layers, one low-level layer for emphasis, indent, etc., and one high-level layer for attributes that need to be converted into low-level attributes before display, e.g. StyleAttribute, HighlightAttribute, etc. This conversion could be done by a shout-like mechanism. Yeah, these are indeed rough ideas, just wanted to collect them anywhere. :-)

Best,
Christoph
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von tim Rowledge <tim at rowledge.org>
Gesendet: Montag, 19. Oktober 2020 02:32:39
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] Improving the SystemNavigation browseMessageList... stuff

OK, review time !

See inbox  Tools-tpr.1003 and System-tpr.1181 for some fairly simple changes to how the message list is built (as a set and sorted etc) and improvements to how the window label is derived.

The only visible change should be that when the window initially opens the label will reflect the fact that the first item is actually selected - the prior code actually started in a weird state with the label that should be used when nothing is selected. I think it is more correct now but one might argue that nothing should be selected by default for this sort of browser.

Now, about that improvement to the Shout stuff...

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Useful random insult:- Wasn't fully debugged before being released.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201024/c688e9e8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 8008 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201024/c688e9e8/attachment.png>