[squeak-dev] The Trunk: Tools-eem.1009.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Oct 27 23:13:53 UTC 2020


Eliot Miranda uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-eem.1009.mcz

==================== Summary ====================

Name: Tools-eem.1009
Author: eem
Time: 27 October 2020, 4:13:50.404335 pm
UUID: 68ca4cb6-ce96-47f0-a039-d760321e60cb
Ancestors: Tools-tpr.1008

The debugger *must not* retain persistent references to objects, thereby preventing garbage colleciton.  This is just asking for Heisenbugs.

=============== Diff against Tools-tpr.1008 ===============

Item was changed:
  ----- Method: Debugger>>saveContextVariablesInspectorState (in category 'user interface') -----
  saveContextVariablesInspectorState
  	"For the user's convenience. Save field selection and user-typed content in the context-variables inspector. See #restoreContextVariablesInspectorState."
  	
  	| stateToSave keyForState |
  	self flag: #duplication.
  	(keyForState := self keyForContextVariablesInspectorState)
  		ifNil: [^ self].
  	contextVariablesInspectorState
+ 		ifNil: [contextVariablesInspectorState := WeakIdentityKeyDictionary new].
- 		ifNil: [contextVariablesInspectorState := IdentityDictionary new].
  	stateToSave := {
  		self contextVariablesInspector selectedFieldName.
  		self contextVariablesInspector contentsTyped }.
  	contextVariablesInspectorState
  		at: keyForState
  		put: stateToSave.!

Item was changed:
  ----- Method: Debugger>>saveReceiverInspectorState (in category 'user interface') -----
  saveReceiverInspectorState
  	"For the user's convenience. Save field selection and user-typed content in the receiver inspector. See #restoreReceiverInspectorState."
  
  	| stateToSave keyForState |
  	self flag: #duplication.
  	(keyForState := self keyForReceiverInspectorState)
  		ifNil: [^ self].
  	receiverInspectorState
+ 		ifNil: [receiverInspectorState := WeakIdentityKeyDictionary new].
- 		ifNil: [receiverInspectorState := IdentityDictionary new].
  	stateToSave := {
  		self receiverInspector selectedFieldName.
  		self receiverInspector contentsTyped }.
  	receiverInspectorState
  		at: keyForState
  		put: stateToSave.!



More information about the Squeak-dev mailing list