Hi Tim,

    no worries, fixed it.  Your redefinition of initializeMessageList:
broke the subclass.  I used an older simpler definition in the subclass to
restore things to normal.

On Thu, Oct 29, 2020 at 9:15 PM Eliot Miranda <eliot.miranda at gmail.com>
wrote:

> Hi Tim,
>
> On Thu, Oct 29, 2020 at 11:11 AM <commits at source.squeak.org> wrote:
>
>> tim Rowledge uploaded a new version of Tools to project The Trunk:
>> http://source.squeak.org/trunk/Tools-tpr.1010.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Tools-tpr.1010
>> Author: tpr
>> Time: 29 October 2020, 11:10:57.263788 am
>> UUID: 1ef23108-8885-419e-ad82-66b42e985086
>> Ancestors: Tools-eem.1009
>>
>> Fix a bug introduced in Tools-tpr.1008 that made window labels go away in
>> a few cases.
>>
>
> Your changes seem to also have broken Recent Changes (don't worry I also
> broke this at Qwaq before I was aware of it; but now I absolutely depend on
> it).  Go to the changes submenu of the World menu, select "Browse Recent
> Submissions (R)", and you get a RecentMessageSet with the most recently
> defined N methods in it.  When working properly every new method
> definition causes the RecentMessageSet to reformulate its list with the new
> method first most.  This is most useful :-)  However, after these recent
> changes it no longer works properly. The new method turns up but somewhere
> further down the lsut, obscuring it hopelessly.  Please fix asap.
>
>
>> =============== Diff against Tools-eem.1009 ===============
>>
>> Item was changed:
>>   ----- Method: ChangedMessageSet
>> class>>openMessageList:name:autoSelect:changeSet: (in category 'opening')
>> -----
>>   openMessageList: messageList name: labelString autoSelect:
>> autoSelectString changeSet: aChangeSet
>>         | messageSet |
>>         messageSet := self messageList: messageList.
>>         messageSet changeSet: aChangeSet.
>> +       messageSet autoSelectString: autoSelectString;
>> +               setInitialLabel: labelString.
>> +       ToolBuilder open: messageSet!
>> -       messageSet autoSelectString: autoSelectString.
>> -       ToolBuilder open: messageSet label: labelString.!
>>
>> Item was changed:
>>   ----- Method: MessageNames class>>openMessageNames (in category
>> 'instance creation') -----
>>   openMessageNames
>>         "Open a new instance of the receiver in the active world"
>> +       ^(ToolBuilder open: self new) model
>> -       ^(ToolBuilder open: self new label: 'Message Names') model
>>
>>         "MessageNames openMessageNames"
>>   !
>>
>> Item was added:
>> + ----- Method: MessageNames>>windowTitle (in category 'toolbuilder')
>> -----
>> + windowTitle
>> +
>> +       ^ 'Message Names'!
>>
>> Item was changed:
>>   ----- Method: MessageSet class>>openMessageList:name: (in category
>> 'instance creation') -----
>> + openMessageList: messageList name: labelString
>> - openMessageList: anArray name: aString
>>         "Create a standard system view for the message set on the list,
>> anArray.
>>         The label of the view is aString."
>>
>> +       self openMessageList: messageList name: labelString autoSelect:
>> nil!
>> -       self open: (self messageList: anArray) name: aString!
>>
>> Item was changed:
>>   ----- Method: MessageSet>>windowTitle (in category 'user interface')
>> -----
>>   windowTitle
>>         "just return the basic label for now"
>>
>> +       ^String streamContents:
>> +               [:str| str nextPutAll: windowLabel;
>> +                                       space;
>> +                                       nextPut: $[;
>> +                                       nextPutAll: messageList size
>> asString;
>> +                                       nextPut: $]
>> +               ]!
>> -       ^windowLabel!
>>
>>
>>
>
> --
> _,,,^..^,,,_
> best, Eliot
>


-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20201029/8cf54fd1/attachment.html>