Karl, great finding! This small number of icons should not matter IMO. Can you put this somewhere into the ReleaseBuilder? :-)


Best,

Christoph

<http://www.hpi.de/>
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von karl ramberg <karlramberg at gmail.com>
Gesendet: Samstag, 19. September 2020 14:32:38
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Inbox: EToys-ct.406.mcz



On Sat, Sep 19, 2020 at 1:33 PM Thiede, Christoph <Christoph.Thiede at student.hpi.uni-potsdam.de<mailto:Christoph.Thiede at student.hpi.uni-potsdam.de>> wrote:

This is good to know, but I wonder whether this is a perfect solution when you want to play a little bit around with some EToys morphs (such as Viewers) without converting your whole image into an EToys optimized one. And you get nowhere informed about the need to activate this EToys mode.


Should we modify the ScriptingSystem so that if an icon is not found, the Squeakland resources are looked up before the default icon is answered? Then you could use all the EToys tools without missing any icon, but still would have your default halo icons etc.

I think we can just add the most obvious ones.
It's not that many.
This should cover the most of them:
assoc := ReleaseBuilderSqueakland scriptingSystemImage109."RoundGoldBox"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage127."Try It Pressed"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage064."Try It"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage038."MenuIcon"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage165."AddCategoryViewer"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage171."AddInstanceVariable"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage014."TanOPressed"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage085."TanO"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage053."Gets"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage080."RightCaret"
ScriptingSystem saveForm: assoc value atKey: assoc key.
assoc := ReleaseBuilderSqueakland scriptingSystemImage044."DownCaret"
ScriptingSystem saveForm: assoc value atKey: assoc key.

Best,
Karl


Best,

Christoph

<http://www.hpi.de/>
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org<mailto:squeak-dev-bounces at lists.squeakfoundation.org>> im Auftrag von David T. Lewis <lewis at mail.msen.com<mailto:lewis at mail.msen.com>>
Gesendet: Freitag, 18. September 2020 23:50:50
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Inbox: EToys-ct.406.mcz

Oh, that's great! I had not noticed it either :-D

Dave

On Fri, Sep 18, 2020 at 04:57:03PM +0200, karl ramberg wrote:
> Ah,
> I have never seen that option :-D
>
> Best,
> Karl
>
>
> On Fri, Sep 18, 2020 at 3:11 PM Marcel Taeumel <marcel.taeumel at hpi.de<mailto:marcel.taeumel at hpi.de>>
> wrote:
>
> > For the 5.3 release, we decided to put that all behind
> > "ReleaseBuilderSqueakland class >> #setEtoysMode" to be triggered from the
> > "Extras > Themes & Colors" docking-bar menu.
> >
> > Best,
> > Marcel
> >
> > Am 17.09.2020 21:51:16 schrieb karl ramberg <karlramberg at gmail.com<mailto:karlramberg at gmail.com>>:
> > I'm not sure it is for space reasons.
> > There could be other conflicts.
> > It seems to change some icons for the handles when you do
> > ReleaseBuilderSqueakland loadDefaultForms
> >
> > Lazy loading of just the missing icons would be awesome.
> >
> > Best,
> > Karl
> >
> >
> > On Thu, Sep 17, 2020 at 9:04 PM Thiede, Christoph <
> > Christoph.Thiede at student.hpi.uni-potsdam.de<mailto:Christoph.Thiede at student.hpi.uni-potsdam.de>> wrote:
> >
> >> Nice finding, Karl! I guess this has not been made part of the usual
> >> ReleaseBuilder for performance (storage) considerations. The question is:
> >> Is this still relevant? Should we lazily load all forms if any is missing
> >> in the ScriptingSystem?
> >>
> >>
> >> Best,
> >>
> >> Christoph
> >> <http://www.hpi.de/>
> >> ------------------------------
> >> *Von:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org<mailto:squeak-dev-bounces at lists.squeakfoundation.org>> im
> >> Auftrag von karl ramberg <karlramberg at gmail.com<mailto:karlramberg at gmail.com>>
> >> *Gesendet:* Donnerstag, 17. September 2020 20:31:31
> >> *An:* The general-purpose Squeak developers list
> >> *Betreff:* Re: [squeak-dev] The Inbox: EToys-ct.406.mcz
> >>
> >>
> >>
> >> On Thu, Sep 17, 2020 at 7:26 PM karl ramberg <karlramberg at gmail.com<mailto:karlramberg at gmail.com>>
> >> wrote:
> >>
> >>> A  note about something to do:
> >>> I noticed that quite a few of the Etoys icons are not added to the
> >>> ScriptingSystem formDictionary.
> >>> So when opening a  ScriptEditorMorph for example, icons like
> >>> 'RoundGoldBox' are missing so the UI is crippled.
> >>> The icons are found in ReleaseBuilderSqueakland but not initialized
> >>>
> >>
> >> You just need to do it:
> >> ReleaseBuilderSqueakland loadDefaultForms
> >> Best,
> >> Karl
> >>
> >>
> >>> Best,
> >>> Karl
> >>>
> >>>
> >>> On Thu, Sep 17, 2020 at 12:42 PM St??phane Rollandin <
> >>> lecteur at zogotounga.net<mailto:lecteur at zogotounga.net>> wrote:
> >>>
> >>>> > This commit is part of reconstruction of Objectland (also known as
> >>>> "The Worlds of Squeak").
> >>>>
> >>>> Cool!
> >>>>
> >>>> Stef
> >>>>
> >>>>
> >>>>
> >>
> >

>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20200919/a66a36eb/attachment.html>