Hmm... *refactoring-core adds #keys to SharedPool class. And "enumerating" already shows #keysDo:, added by tpr in 2004. :-)

I vote for adding #values to SharedPool class. The goal is to make it polymorphic with Dictionary. There is not only SpaceTally out there. ;-)

The list of implementors of #values is rather compact.

Best,
Marcel
Am 21.08.2021 21:14:32 schrieb tim Rowledge <tim at rowledge.org>:
When trying a SpaceTally in the 20601 image it fails because a SharedPool does not understand #values. See SpaceTally>>#computeSpaceUsage and SpaceTally>>#spaceForPoolsOf:depth:seen: which appears to have been changed from the 5.3 code at the end of last year. Guess that shows how long since I last tried it in a 6.0alpha image...

Simple fix suggestion -


Yes, one could simply implement #values in SharedPool but I consider decently descriptive message names to be very helpful in understanding what is going on. Otherwise we might as well just use numbers...

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim [http://www.rowledge.org/tim]
Strange OpCodes: MAW: Make Aggravating Whine



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210823/6e263e87/attachment.html>