[squeak-dev] The Trunk: Tools-mt.1084.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Dec 8 17:01:20 UTC 2021

Marcel Taeumel uploaded a new version of Tools to project The Trunk:

==================== Summary ====================

Name: Tools-mt.1084
Author: mt
Time: 8 December 2021, 6:01:17.428213 pm
UUID: 89ac14d0-d8d6-b845-a717-3f3d2afc0feb
Ancestors: Tools-mt.1083

In regular inspectors, fixes lookup of truncated elements in dynamically-sized objects. Note that you should still use the proper CollectionInspector if you are actually inspecting a collection. :-)

=============== Diff against Tools-mt.1083 ===============

Item was changed:
  ----- Method: CodeHolder>>annotationPaneHeight (in category 'toolbuilder') -----
+ 	^ (Preferences standardDefaultTextFont height * 3/2) truncated!
- 	^ (Preferences standardCodeFont height * 3/2) rounded!

Item was changed:
  ----- Method: Inspector>>contentsForTruncationOf: (in category 'fields - truncation') -----
  contentsForTruncationOf: truncatedKeys
+ 	^ ('<Fields named {1} to {2} are not shown. {3} to inspect one of those fields or select "inspect element" from the field list menu.>' translated asText
- 	^ ('<Fields named {1} to {2} are not shown. {3} to inspect one of those fields or select "inspect element" from any field''s menu.>' translated asText
  		addAttribute: TextEmphasis italic;
  		format: {
  			truncatedKeys first storeString.
  			truncatedKeys last storeString. 
  			'Click here' translated asText
  				addAttribute: (PluggableTextAttribute evalBlock: [self inspectOneOf: truncatedKeys]);
  				yourself. })!

Item was changed:
+ ----- Method: Inspector>>elementAt: (in category 'private - collections') -----
- ----- Method: Inspector>>elementAt: (in category 'menu - private') -----
  elementAt: indexOrKey
  	"Backstop to simplify #inspectOne for all kinds of inspectors."
  	^ (self elementGetterAt: indexOrKey) value: self object!

Item was changed:
+ ----- Method: Inspector>>elementGetterAt: (in category 'private - collections') -----
- ----- Method: Inspector>>elementGetterAt: (in category 'menu - private') -----
  elementGetterAt: indexOrKey
  	"Backstop to simplify #inspectOne for all kinds of inspectors."
+ 	^ [:object | object basicAt: indexOrKey]!
- 	^ [:object | (self fields detect: [:field | field key = indexOrKey]) getValueFor: self] !

Item was changed:
  ----- Method: Inspector>>inspectOne (in category 'menu - commands') -----
  	"This is the most generic case to inspect a specific element from the inspected object. Since trunction of fields is a generic feature, support lookup for those truncated objects also for non-collections."
+ 	self inspectOneOf: (1 to: self object basicSize).!
- 	self inspectOneOf: (
- 		self fields
- 			select: [:field | field key notNil]
- 			thenCollect: [:field | field key]).!

More information about the Squeak-dev mailing list