[squeak-dev] The Inbox: Tools-ct.1087.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 10 19:35:25 UTC 2021


A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-ct.1087.mcz

==================== Summary ====================

Name: Tools-ct.1087
Author: ct
Time: 10 December 2021, 8:35:22.779895 pm
UUID: 98cd5e93-8af1-c248-b69f-c245920124c6
Ancestors: Tools-mt.1085

Proposal: Makes *Tools protocol on Object not suppress return values from the toolset. Sometimes you might want to refer to the opened tool window, and in the other way around, assuming that "5 inspect == 5" would not be good style either. IMO forwarding return values should be the norm and supressing them should be the exception.

Examples:

	WatchMorph new inspect model selectFieldNamed: #screenshot
	World explore fullScreen.

=============== Diff against Tools-mt.1085 ===============

Item was changed:
  ----- Method: MessageSet>>browseAllImplementorsOf: (in category 'message functions') -----
  browseAllImplementorsOf: selectorSymbol
+ 
+ 	^ self systemNavigation browseAllImplementorsOf: selectorSymbol!
- 	self systemNavigation browseAllImplementorsOf: selectorSymbol!

Item was changed:
  ----- Method: MessageTrace>>browseAllCallsOn: (in category 'actions') -----
  browseAllCallsOn: selectorSymbol
+ 
+ 	^ (self hasUnacceptedEdits or: [ Preferences traceMessages not ])
- 	(self hasUnacceptedEdits or: [ Preferences traceMessages not ])
  		ifTrue: [ super browseAllCallsOn: selectorSymbol ]
  		ifFalse: [ self addParentMethodsSending: selectorSymbol ]!

Item was changed:
  ----- Method: MessageTrace>>browseAllImplementorsOf: (in category 'actions') -----
  browseAllImplementorsOf: selectorSymbol
  	| selectorToBrowse |
  	selectorToBrowse := self selection 
  		ifNil: [ selectorSymbol ] 
  		ifNotNil: [ self getImplementorNamed: selectorSymbol asSymbol "since we can get passed literals"].
+ 	^ (self hasUnacceptedEdits or: [ Preferences traceMessages not ])
- 	(self hasUnacceptedEdits or: [ Preferences traceMessages not ])
  		ifTrue: [ super browseAllImplementorsOf: selectorToBrowse ]
  		ifFalse: [ self addChildMethodsNamed: selectorToBrowse ]
  !

Item was changed:
  ----- Method: Object>>basicInspect (in category '*Tools-Inspector') -----
  basicInspect
+ 	"Create and schedule an Inspector in which the user can examine the receiver's variables. This method should not be overriden."
+ 
+ 	^ ToolSet basicInspect: self!
- 	"Create and schedule an Inspector in which the user can examine the 
- 	receiver's variables. This method should not be overriden."
- 	ToolSet basicInspect: self!

Item was changed:
  ----- Method: Object>>browse (in category '*Tools-Browsing') -----
  browse
+ 
+ 	^ ToolSet browseClass: self class!
- 	ToolSet browseClass: self class!

Item was changed:
  ----- Method: Object>>browseAllCallsOn: (in category '*Tools-MessageSets') -----
  browseAllCallsOn: selectorSymbol
  	"Models get the first chance to handle this, so a message-tracer can be built..  Not all Tool 'models' inherit from Model, otherwise this would be there."
+ 
+ 	^ self systemNavigation browseAllCallsOn: selectorSymbol!
- 	self systemNavigation browseAllCallsOn: selectorSymbol!

Item was changed:
  ----- Method: Object>>browseAllImplementorsOf: (in category '*Tools-MessageSets') -----
  browseAllImplementorsOf: selectorSymbol
  	"Models get first chance to handle browseAllImplementorsOf:, so a tracing-messages browser can be built..  Not all Tool 'models' inherit from Model, otherwise this would be there."
+ 
+ 	^ self systemNavigation browseAllImplementorsOf: selectorSymbol!
- 	self systemNavigation browseAllImplementorsOf: selectorSymbol!

Item was changed:
  ----- Method: Object>>chasePointers (in category '*Tools-Debugger') -----
  chasePointers
+ 
+ 	^ PointerFinder on: self!
- 	PointerFinder on: self!

Item was changed:
  ----- Method: Object>>explore (in category '*Tools-Explorer') -----
  explore
+ 
+ 	^ ToolSet explore: self!
- 	ToolSet explore: self!

Item was changed:
  ----- Method: Object>>explorePointers (in category '*Tools-Debugger') -----
  explorePointers
+ 
+ 	^ PointerExplorer openOn: self!
- 	PointerExplorer openOn: self!

Item was changed:
  ----- Method: Object>>exploreWithLabel: (in category '*Tools-Explorer') -----
  exploreWithLabel: label
+ 
+ 	^ ToolSet explore: self label: label!
- 	ToolSet explore: self label: label!

Item was changed:
  ----- Method: Object>>inspect (in category '*Tools-Inspector') -----
  inspect
  	"Create and schedule an Inspector in which the user can examine the receiver's variables."
+ 
+ 	^ ToolSet inspect: self!
- 	ToolSet inspect: self!

Item was changed:
  ----- Method: Object>>inspectWithLabel: (in category '*Tools-Inspector') -----
  inspectWithLabel: aLabel
  	"Create and schedule an Inspector in which the user can examine the receiver's variables."
+ 
+ 	^ ToolSet inspect: self label: aLabel!
- 	ToolSet inspect: self label: aLabel!



More information about the Squeak-dev mailing list