[squeak-dev] The Trunk: Morphic-ct.1825.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Wed Dec 15 16:51:25 UTC 2021


I think that the actual issue here is that the changes list does not honor "menu with icons" preference.

Am 15.12.2021 17:49:42 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:


Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Mittwoch, 15. Dezember 2021 17:48:48
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-ct.1825.mcz
Christoph Thiede uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-ct.1825.mcz [http://source.squeak.org/trunk/Morphic-ct.1825.mcz]

==================== Summary ====================

Name: Morphic-ct.1825
Author: ct
Time: 15 December 2021, 5:48:39.540981 pm
UUID: 51a9514e-bff7-5e42-92be-97336b8b1b8e
Ancestors: Morphic-mt.1824

Slightly revises appearance of the changes menu in the docking bar: Unifies the indentation of icons if the preference "colorful windows" is disabled.

=============== Diff against Morphic-mt.1824 ===============

Item was changed:
  ----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') -----
  listChangesOn: menu
         | fetchChangesBlock |
                 'Browse current change set' translated. #browseChangeSet. nil.
                 'Browse changed methods' translated. #browseChangedMethods. nil.
                 nil. nil. nil.
                 'Simple Change Sorter' translated.      #browseChanges. ChangeSorter.
                 'Dual Change Sorter' translated. #browseChangesDual. DualChangeSorter.
                 nil. nil. nil.
         } groupsDo: [:label :selector :modelClass |
                 label ifNil: [menu addLine] ifNotNil: [
                         menu addItem: [:item |
                                         contents: label;
+                                        icon: ((modelClass ifNotNil: [self colorIcon: modelClass basicNew windowColorToUse])
+                                                ifNil: [MenuIcons blankIcon]);
-                                        icon: (modelClass ifNotNil: [self colorIcon: modelClass basicNew windowColorToUse]);
                                         target: self;
                                         selector: selector]] ].
         fetchChangesBlock := [ | latestMethodChanges latestClassChanges updateBlock |
                 self flag: #concurrency. "mt: Is this safe enough given the current update frequency of change sets and when this code is executed?"
                 latestMethodChanges := (Array streamContents: [:s |
                         ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category |
                                 s nextPut: { dateAndTime. method. changeType. category }]])
                                 sorted: [:a :b | a first >= b first].
                 latestClassChanges := (Array streamContents: [:s |
                         ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category |
                                 "We are not interested in classes whose method's did only change."
                                 changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]])
                                 sorted: [:a :b | a first >= b first].
                 updateBlock := [self listMethodChanges: latestMethodChanges andClassChanges: latestClassChanges on: menu].
                 Project current uiProcess == Processor activeProcess
                         ifTrue: updateBlock
                         ifFalse: [Project current addDeferredUIMessage: [
                                 menu isInWorld ifTrue: [menu lastItem delete. updateBlock value]] ]].
         ChangeSet current numberOfChanges <= 30
                 ifTrue: fetchChangesBlock ifFalse: [
                         "We have too much data to process. Do it in the background to keep the UI responsive."
                         menu add: '... fetching changes ...' translated action: nil.
                         menu lastItem isEnabled: false.
                         fetchChangesBlock forkAt: Processor userBackgroundPriority].!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211215/bb8e4e35/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 9823 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211215/bb8e4e35/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 17327 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211215/bb8e4e35/attachment-0001.png>

More information about the Squeak-dev mailing list