No need to apologize, this was a nice debugging exercise. :D


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von David T. Lewis <lewis at mail.msen.com>
Gesendet: Freitag, 17. Dezember 2021 04:14:46
An: squeak-dev at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Trunk: System-ct.1269.mcz

Thanks Christoph and Jaromir for finding and fixing this, and I
sincerely apologize for introducing the change without testing it
properly with #processPreemptionYields.

Thank you!
Dave


On Fri, Dec 17, 2021 at 12:23:08AM +0000, commits at source.squeak.org wrote:
> Christoph Thiede uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-ct.1269.mcz
>
> ==================== Summary ====================
>
> Name: System-ct.1269
> Author: ct
> Time: 17 December 2021, 1:23:02.870987 am
> UUID: 6e5ae88f-54c6-0445-8ec4-9f0005e2a14a
> Ancestors: System-ct.1268
>
> Revises SmalltalkImage >> #vmParameterAt:ifAbsent:. Avoids running defaultValueOrBlock inside the internal error handler.
>
> Thanks to Jaromir (jar) for the warning!
>
> =============== Diff against System-ct.1268 ===============
>
> Item was changed:
>   ----- Method: SmalltalkImage>>vmParameterAt:ifAbsent: (in category 'vm parameters') -----
>   vmParameterAt: parameterIndex ifAbsent: defaultValueOrBlock
> +      "Answer a VM parameter or defaultValueOrBlock value if out of range or if the VM does not provide a value for this parameter. A VM parameter is typically numeric or boolean, and if not implemented will be nil."
> +      ^ ([self vmParameterAt: parameterIndex]
> +              on: Error do: [])
> +                      ifNil: [defaultValueOrBlock value]!
> -      "Answer a VM parameter or defaultValueOrBlock value if out of range
> -      or if the VM does not provide a value for this parameter. A VM parameter
> -      is typically numeric or boolean, and if not implemented will be nil."
> -      ^ [(self vmParameterAt: parameterIndex)
> -                      ifNil: [^ defaultValueOrBlock value]]
> -              on: Error
> -              do: [defaultValueOrBlock value]!
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211217/48f83992/attachment.html>