[squeak-dev] ChangeSorter preamble eating seems to break broken

tim Rowledge tim at rowledge.org
Thu Dec 30 20:49:49 UTC 2021

> On 2021-12-30, at 1:05 AM, Marcel Taeumel <marcel.taeumel at hpi.de> wrote:
> Hi Tim --
> > Marcel, what was your intent for that change?
> It was gone by accident. I wanted to minimize the interaction/clicks when working/managing change sets.

Ah, right. I can see why you might want that.

> Could we spawn an extra window just like with "postscripts"? (Yellow-click on change set, edit/add potsscript, new window appears)

Well oddly enough, the (unused) ChangeSorter>>#editPreamble method purports to do just that. In ChangeSorter>>#unshiftedChangeSetMenu: it looks as if at one point the expectation was to send it but #addPreamble got used instead. No idea why.

However, it looks like it it really easy to solve this. The problem is that ChangeSorter>>#addPreamble has been using the massive hammer of `self showChangeSet: myChangeSet` since 1999 when al that is required is
`		self changed: #messageList.
		self setContents.
		self contentsChanged`

Try this - 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TPR-ChangeBrowser-preamble.1.cs
Type: application/octet-stream
Size: 743 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211230/e4cac07b/attachment.obj>
-------------- next part --------------

tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Strange OpCodes: STOP: No Op

More information about the Squeak-dev mailing list