[squeak-dev] The Trunk: System-cmm.1214.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Feb 6 04:25:20 UTC 2021


Chris Muller uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-cmm.1214.mcz

==================== Summary ====================

Name: System-cmm.1214
Author: cmm
Time: 5 February 2021, 10:09:05.179247 pm
UUID: d6f968d9-a638-42ef-89ef-d37af0f31ffd
Ancestors: System-mt.1213

Patch the patcher.  Smalltalk run: permits the patching of a production system without having to resort to running a custom image, but when the patch.st file has read-only status in the OS, FileStream class>>#fileNamed:do: can't open it, because it tries to open for read/write.  But rather htan signal an error, it silently does nothing (wow), leaving the system unpatched.
	Patch files can and should be read-only anyway, so use DirectoryEntryFile>>#readStreamDo:.

=============== Diff against System-mt.1213 ===============

Item was changed:
  ----- Method: SmalltalkImage>>patchSystem (in category 'command line') -----
  patchSystem
  	'patch.st' asDirectoryEntry ifNotNil:
  		[ : patchEntry | patchEntry modificationTime > Smalltalk imageName asDirectoryEntry modificationTime
  			ifTrue:
  				[ Notification signal: 'Patching system...'.
+ 				patchEntry readStreamDo: [ : stream | stream fileIn ] ]
- 				FileStream
- 					fileNamed: 'patch.st'
- 					do:
- 						[ : stream | stream fileIn ] ]
  			ifFalse: [ self error: 'patch.st file is older than the image file.  Aborting.' ] ]!



More information about the Squeak-dev mailing list