[squeak-dev] The Inbox: Monticello-nice.734.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Tue Jan 5 12:09:48 UTC 2021

Hi Nicolas.

> If you can think of nicer fix, please raise voice.

I just put Monticello-mt.734 into the inbox. Please take a look and decide for yourself. :-)

Am 30.12.2020 15:57:30 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of Monticello was added to project The Inbox:

==================== Summary ====================

Name: Monticello-nice.734
Author: nice
Time: 30 December 2020, 3:57:21.60758 pm
UUID: 863f642a-7795-4eb6-aa6b-76a5af3a8504
Ancestors: Monticello-mt.733

Workaround version history browser bug when 'working copy' is selected.

The snapshot is searched in repositoryGroup, and logically, none is found.
Note that the self selectedInfo isKindOf: MCWorkingCopyAncestry, which does not behave as a regular MCVersionInfo, it does not even answer to versionName...
This somehow accelerate the failure thru an ifError: [] handling, but at the end, the selectedSnapshot is still nil which makes the 'view changes from...' menu fail.

The workaround is not very nice, it use implicit knowledge that 'working copy' will be at top of list (index = 1).

If you can think of nicer fix, please raise voice.

=============== Diff against Monticello-mt.733 ===============

Item was changed:
----- Method: MCVersionHistoryBrowser>>selectedSnapshot (in category 'accessing') -----
+ index = 1 ifTrue: [^package snapshot].
^ self snapshotForInfo: self selectedInfo!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210105/8b70f0b5/attachment.html>

More information about the Squeak-dev mailing list