It looks like it is 2 pixels short for height.  If the size list size is
between 5 and 15, it will include the vertical scroll bar to scroll for
those 2 pixels (or, I am guessing, however big the list box boundary line
is).

It looks like the width is short by the padding size before and after the
text - maybe adding an $m width to the horizontal size would make it better
(or figure out what the right padding + list box boundary line width is and
add it in).

On Mon, Jan 11, 2021 at 10:17 AM Chris Cunningham <cunningham.cb at gmail.com>
wrote:

> [image: image.png]
> and
> [image: image.png]
> close enough.
>
> On Mon, Jan 11, 2021 at 10:16 AM <commits at source.squeak.org> wrote:
>
>> A new version of ToolBuilder-Morphic was added to project The Inbox:
>> http://source.squeak.org/inbox/ToolBuilder-Morphic-cbc.271.mcz
>>
>> ==================== Summary ====================
>>
>> Name: ToolBuilder-Morphic-cbc.271
>> Author: cbc
>> Time: 11 January 2021, 10:15:51.0644 am
>> UUID: 76f9fb95-5700-1b43-a9af-9ab88aaa890f
>> Ancestors: ToolBuilder-Morphic-mt.270
>>
>> Let the width of List Chooser try to accomodate better to the actual size
>> of the string.
>>
>> =============== Diff against ToolBuilder-Morphic-mt.270 ===============
>>
>> Item was changed:
>>   ----- Method: ListChooser>>initialExtent (in category 'building') -----
>>   initialExtent
>> +       | listFont itemCount width |
>> -
>> -       | listFont itemCount maxItemSize cellSize |
>>         listFont := Preferences standardListFont.
>>         itemCount := items size.
>> +       width := ((items take: 15) collect: [:item| listFont
>> widthOfString: item]) max.
>> +       ^ (width min: (self currentWorld extent x * 0.75) asInteger max:
>> ((listFont widthOf: $m) * 12))
>> +               @ ((itemCount min: 15 max: 5) * listFont height + self
>> searchBarHeight)
>> + !
>> -       maxItemSize := items inject: 0 into: [:max :item | max max: item
>> size].
>> -       cellSize := (listFont widthOf: $m) @ listFont height.
>> -
>> -       ^ ((maxItemSize + 1 "breathing space" min: 20 max: 10)
>> -               @ (itemCount + 1 "breathing space" min: 15 max: 5)
>> -               * cellSize) + (0@ self searchBarHeight)!
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210111/2204ef22/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 12781 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210111/2204ef22/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 18053 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210111/2204ef22/attachment-0003.png>