[squeak-dev] The Inbox: Kernel-ct.1368.mcz
Eliot Miranda
eliot.miranda at gmail.com
Tue Jan 26 01:05:05 UTC 2021
Hi David,
On Sun, Jan 24, 2021 at 8:10 AM David T. Lewis <lewis at mail.msen.com> wrote:
> I like this proposal. It has no effect on the ProcessBrowser, and is
> helpful when looking at processes elsewhere.
>
> Most processes do not have a name, but all processes respond in a concise
> and useful way to #name.
>
> Process>>name
> ^name ifNil: [ self hash asString forceTo: 5 paddingStartWith: $ ]
>
5 is too short. The identityHash in Spur has 7 digits of significance and
hash => scaledIdentityHash => identityHash * 256. Also asString is lazy;
it just calls printString. I wouldn't contract at all:
Process>>name
^name ifNil: [self hash printString]
> So +1 from me
>
> Dave
>
> On Sun, Jan 24, 2021 at 03:28:20PM +0000, Thiede, Christoph wrote:
> > Hi Eliot,
> >
> >
> > thanks for the feedback! I actually intended to print their short hash
> if they don't have a real name because this can still be very helpful in
> order to differentiate between multiple processes each suspended in the
> same method. It would also help me to identify a process from the process
> browser somewhere else. Do you get my point? :-)
> >
> >
> > Best,
> >
> > Christoph
> >
> > <http://www.hpi.de/>
> > ________________________________
> > Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im
> Auftrag von Eliot Miranda <eliot.miranda at gmail.com>
> > Gesendet: Sonntag, 24. Januar 2021 15:55:42
> > An: squeak-dev at lists.squeakfoundation.org
> > Betreff: Re: [squeak-dev] The Inbox: Kernel-ct.1368.mcz
> >
> > Hi Christoph,
> >
> > only a few processes have a name. Surely this should test from
> there being a name and not print some noise if it doesn???t have a name.
> >
> > _,,,^..^,,,_ (phone)
> >
> > > On Jan 24, 2021, at 6:19 AM, commits at source.squeak.org wrote:
> > >
> > > ???A new version of Kernel was added to project The Inbox:
> > > http://source.squeak.org/inbox/Kernel-ct.1368.mcz
> > >
> > > ==================== Summary ====================
> > >
> > > Name: Kernel-ct.1368
> > > Author: ct
> > > Time: 24 January 2021, 3:19:48.003384 pm
> > > UUID: c62a6062-b240-9149-a2ed-78fdc1079dfd
> > > Ancestors: Kernel-mt.1364
> > >
> > > Proposal: Always include process name into its print string. This
> facilitates debugging/inspecting of multiprocess scenarios.
> > >
> > > =============== Diff against Kernel-mt.1364 ===============
> > >
> > > Item was changed:
> > > ----- Method: Process>>longPrintOn: (in category 'printing') -----
> > > longPrintOn: stream
> > >
> > > | ctxt |
> > > super printOn: stream.
> > > + stream
> > > + nextPut: $(;
> > > + nextPutAll: self name;
> > > + nextPut: $).
> > > stream cr.
> > > ctxt := self suspendedContext.
> > > [ctxt == nil] whileFalse: [
> > > stream space.
> > > ctxt printOn: stream.
> > > stream cr.
> > > ctxt := ctxt sender.
> > > ].
> > > !
> > >
> > > Item was changed:
> > > ----- Method: Process>>printOn: (in category 'printing') -----
> > > printOn: aStream
> > >
> > > super printOn: aStream.
> > > + aStream
> > > + nextPut: $(;
> > > + nextPutAll: self name;
> > > + nextPut: $).
> > > aStream nextPutAll: ' in '.
> > > suspendedContext printOn: aStream!
> > >
> > >
> >
>
> >
>
>
>
--
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210125/2a9f081f/attachment.html>
More information about the Squeak-dev
mailing list
|