[squeak-dev] Bag>>#rehash missing

Marcel Taeumel marcel.taeumel at hpi.de
Sat Mar 6 10:48:37 UTC 2021


Hi Patrick.

+1 on adding #rehash for Bag ... although it technically depends on #contentsClass ? Hmmm...

+0.5 on making #rehash non-private. Hmm.... maybe "initialization" would be a fitting category. Well, definitely not "update" or something like that. Clients should normally not call it, right?

Best,
Marcel
Am 05.03.2021 20:12:19 schrieb Rein, Patrick <patrick.rein at hpi.de>:
Hi everyone,

during a recent debugging session I noticed that Bag does not implement #rehash although it is, in essence, a hash-based collection and should therefore probably roughly adhere to the protocol of HashedCollection. Is there a good reason not to have #rehash on Bag?

On a similar note: HashedCollection>>#rehash is in the `private` protocol but has various senders. As even the class comment mentions the usage of #rehash, I would also propose to move it out of the `private` protocol. :)

Best wishes,
Patrick

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210306/d49dec72/attachment.html>


More information about the Squeak-dev mailing list