Alright. Are you criticizing my change or only the attached description? :-)


Best,

Christoph

<http://www.hpi.de/>
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Freitag, 7. Mai 2021 19:26:32
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1769.mcz

Ah. Then #transparent ~= #translucent =)

Best,
Marcel

Am 06.05.2021 23:15:41 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:

Well, I actually wanted to prevent a window from automatically applying the color of its first child, which is often a transparent panel morph. Recently we had a student complaining that his window was completely lacking color:


ToolBuilder open: (PluggableWindowSpec new
children: {PluggablePanelSpec new
    frame: (LayoutFrame new
topFraction: 1;
    yourself);
yourself};
yourself).

[cid:aec6fc25-f9d7-4f33-b2f9-cfa2fd4ba205]

This is because only Model implements #windowColorToUse.
Note that #windowColorToUse, #paneColor, and #defaultColor can still be used to set a translucent color. But I'm not sure whether it is a good idea to derive a transparent color from a child ...

Best,
Christoph
<http://www.hpi.de/>
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 6. Mai 2021 20:32:24
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1769.mcz

> Avoid translucent color.

Why? I did cut out the drop shadow. Translucent windows colors look so cool! :-D
[cid:ef11b7be-3360-426c-81a3-b06a1b7d5df7]

Am 01.05.2021 14:12:32 schrieb commits at source.squeak.org <commits at source.squeak.org>:

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1769.mcz

==================== Summary ====================

Name: Morphic-ct.1769
Author: ct
Time: 1 May 2021, 2:12:17.510389 pm
UUID: aa271c07-344a-324a-afe4-3950d6c00839
Ancestors: Morphic-mt.1767

Make SystemWindow's paneColor more robust against missing models. Avoid translucent color.

=============== Diff against Morphic-mt.1767 ===============

Item was changed:
----- Method: SystemWindow>>paneColor (in category 'colors') -----
paneColor
| cc |
(cc := self valueOfProperty: #paneColor) ifNotNil: [^cc].
(model respondsTo: #windowColorToUse) ifTrue: [cc := model windowColorToUse].
+ cc ifNil: [cc := paneMorphs
+ detect: [:morph | morph color isTransparent not]
+ ifFound: [:morph | morph color asNontranslucentColor]
+ ifNone: [nil]].
- cc ifNil: [cc := paneMorphs isEmptyOrNil ifFalse: [paneMorphs first color]].
cc ifNil: [cc := self defaultColor].
self paneColor: cc.
^cc!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/bd391f9a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 57317 bytes
Desc: image.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/bd391f9a/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 15764 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/bd391f9a/attachment-0003.png>