Nice catch! :-)


For anyone else wondering about this glitch:

Before:

[cid:fa526f81-7fe1-4dca-8487-be1c5bc0731b]

After:
[cid:3b6aa025-5213-4b7a-80f9-d3ae74dbbfe9]

IMO our printing protocol on Number should have a padded argument similar to the (post-comma) decimal places.
Apart from that, I would have expected '-02' instead of '- 02'. :-)

Best,
Christoph
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 6. Mai 2021 19:05:29
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.1769.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1769.mcz

==================== Summary ====================

Name: Morphic-mt.1769
Author: mt
Time: 6 May 2021, 7:05:24.828981 pm
UUID: 8109f744-f1f3-7048-8646-fed21a8e23d4
Ancestors: Morphic-ct.1768

Fixes minor glitch in objext explorers on integers.

This makes me wonder ... what are the expectations for negative integers here?

=============== Diff against Morphic-ct.1768 ===============

Item was changed:
  ----- Method: Integer>>explorerContents (in category '*Morphic-Explorer') -----
  explorerContents

         ^#(
                 ('hexadecimal' 16 2)
                 ('octal' 8 3)
                 ('binary' 2 4)) collect: [ :each | | label group |
                         group := each third.
+                        label := self abs printStringBase: each second.
-                        label := self printStringBase: each second.
                         label := label padded: #left to: (label size roundUpTo: group) with: $0.
                                 label := String streamContents: [:s |
+                                self negative ifTrue: [s nextPutAll: '- '].
                                 (1 to: label size by: group)
                                         do: [:index |
                                                 1 to: group do: [:gIndex |
                                                         s nextPut: (label at: index + gIndex - 1)]]
                                         separatedBy: [s space]].

                         ObjectExplorerWrapper
                                 with: label
                                 name: each first translated
                                 model: self ]!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/ada64623/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 8037 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/ada64623/attachment.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 7983 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210517/ada64623/attachment-0001.png>