[squeak-dev] The Trunk: Network-jar.250.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Nov 27 19:59:50 UTC 2021

Christoph Thiede uploaded a new version of Network to project The Trunk:

==================== Summary ====================

Name: Network-jar.250
Author: jar
Time: 12 November 2021, 10:07:25.383788 pm
UUID: fe957845-b8bb-e143-8e58-e4e886f51bac
Ancestors: Network-eem.249

Allow No authentication SMTP login for an empty username (in addition to a nil username). 

Currently, if the username is nil the AUTH LOGIN command won't be sent; however if the username is empty ('') the AUTH LOGIN will be sent and the server may not like it and return an error message. This behavior prevents Squeak Inbox Talk tool (ct) from using simple no auth SMTP server to send messages.

=============== Diff against Network-eem.249 ===============

Item was changed:
  ----- Method: SMTPClient>>login (in category 'private protocol') -----
  	"Send HELO first"
  	self initiateSession.
  	self user ifNil: [^self].
+ 	self user ifEmpty: [^self].
  	self sendCommand: 'AUTH LOGIN ' , (self encodeString: self user).
  	[self checkResponse]
  		on: TelnetProtocolError
  		do: [ :ex | ex isCommandUnrecognized ifTrue: [^ self] ifFalse: [ex pass]].
  	self sendCommand: (self encodeString: self password).
  	self checkResponse!

More information about the Squeak-dev mailing list