[squeak-dev] The Trunk: Kernel-ct.1423.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Sat Nov 27 21:10:11 UTC 2021

Understood. Done in Kernel-ct.1426.



Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda at gmail.com>
Gesendet: Freitag, 26. November 2021 06:20:46
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Trunk: Kernel-ct.1423.mcz

On Thu, Nov 25, 2021 at 3:58 AM Marcel Taeumel <marcel.taeumel at hpi.de<mailto:marcel.taeumel at hpi.de>> wrote:
Actually, the #automaticPlatformSettings preference is not really used except in SoundPlayer. Furthermore, even that use case seems to just fine-tune platform-specific "atmosphere" and not critical features such as keyboard input (and virtual keys).

Let's remove that preference as long as it's simple to do. Having such a thing widely used and then turned "off" my mistake can yield all kinds of strange bugs, debuggers, and questions in the mailing list.



Am 25.11.2021 12:44:27 schrieb Marcel Taeumel <marcel.taeumel at hpi.de<mailto:marcel.taeumel at hpi.de>>:

I don't buy it. It's like a "turn off bugs" feature, which cannot practically exist. One can test features on different platforms without having such a preference in Trunk available for everybody.

We should remove this preference ASAP. It is misleading.


Am 25.11.2021 12:29:06 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de<mailto:christoph.thiede at student.hpi.uni-potsdam.de>>:

Hi Marcel,

under normal constraints, I would also not recommend turning off this preference. But I can imagine that it might be helpful for debugging purposes, for instance, if you want to test the behavior for another platform ...



Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org<mailto:squeak-dev-bounces at lists.squeakfoundation.org>> im Auftrag von Taeumel, Marcel
Gesendet: Donnerstag, 25. November 2021 11:53:06
An: squeak-dev
Betreff: Re: [squeak-dev] The Trunk: Kernel-ct.1423.mcz

I am surprised that such a preference exists since it is an implicit contract to always write code that runs on all supported platforms.

We should remove this preference ASAP. It is misleading.


Am 25.11.2021 11:35:06 schrieb commits at source.squeak.org<mailto:commits at source.squeak.org> <commits at source.squeak.org<mailto:commits at source.squeak.org>>:

Christoph Thiede uploaded a new version of Kernel to project The Trunk:

==================== Summary ====================

Name: Kernel-ct.1423
Author: ct
Time: 25 November 2021, 11:34:19.428424 am
UUID: ec2f69bf-0aac-4747-8cc5-5778a713051f
Ancestors: Kernel-mt.1422

Honors Preferences automaticPlatformSettings in EventSensor startUp:.

=============== Diff against Kernel-mt.1422 ===============

Item was changed:
----- Method: EventSensor class>>startUp: (in category 'system startup') -----
startUp: resuming
+ (resuming and: [Preferences automaticPlatformSettings]) ifTrue: [
- resuming ifTrue: [
Smalltalk platformName = 'Mac OS'
ifTrue: [
self mapAltKeysToOptionKeys: false.
self mapControlKeysToCommandKeys: false]
ifFalse: [
self mapAltKeysToOptionKeys: true.
self mapControlKeysToCommandKeys: true].
self installVirtualKeyTable ].

self default startUp.!

best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211127/30bfb2c2/attachment.html>

More information about the Squeak-dev mailing list