[squeak-dev] The Trunk: Morphic-eem.1790.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Mon Nov 29 16:52:24 UTC 2021

Hi Christoph --

This looks rather like a regression fix that is long overdue. See ParagraphEditor >> #makeProjektLink.

Other than that: You are right. Coupling needs to decreased! Code needs to be documented! Context menus are crowded already! :-) So, let's work on that.

Am 27.11.2021 20:34:20 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Eliot,

doesn't this increase the coupling between editing and projects management even more?

Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 11. November 2021 18:11:49
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-eem.1790.mcz
Eliot Miranda uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-eem.1790.mcz [http://source.squeak.org/trunk/Morphic-eem.1790.mcz]

==================== Summary ====================

Name: Morphic-eem.1790
Author: eem
Time: 11 November 2021, 9:11:46.040429 am
UUID: fcf3f31e-f485-42d4-8863-29f2e3c2afed
Ancestors: Morphic-eem.1789

Implement "make project link (P)" for the Morphic help editor.

=============== Diff against Morphic-eem.1789 ===============

Item was added:
+ ----- Method: PluggableTextMorph>>makeProjectLink (in category 'menu commands') -----
+ makeProjectLink
+        self handleEdit: [textMorph editor makeProjectLink]!

Item was added:
+ ----- Method: TextEditor>>makeProjectLink (in category 'menu commands') -----
+ makeProjectLink
+        | attribute thisSel |
+        thisSel := self selection.
+        attribute := TextSqkProjectLink new.
+        thisSel := attribute analyze: self selection asString.
+        thisSel ifNil: [^ true].
+        self replaceSelectionWith: (thisSel asText addAttribute: attribute).
+        ^ true!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211129/8d215794/attachment.html>

More information about the Squeak-dev mailing list