[squeak-dev] The Inbox: Morphic-ct.1787.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Wed Oct 20 07:09:46 UTC 2021

Hi Christoph --

Sure, if it makes sense to you, do it. :-) Well, Morphic's #handles* methods don't scale-up too well. For short implementations of #mouseDown:/#keyStroke: etc., it makes sense to separate such conditions, though.

Am 19.10.2021 19:34:55 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,

I was trying to replicate the style from #mouseDown: & Co. Shall I also move the checks there into the relevant #handlesMouse...: selectors?

Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 19. Oktober 2021 15:39:41
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1787.mcz
This check should be implemented via #handlesKeyboard:, not in #keyStroke:.

Am 18.10.2021 18:00:38 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of Morphic was added to project The Inbox:

==================== Summary ====================

Name: Morphic-ct.1787
Author: ct
Time: 18 October 2021, 6:00:19.065559 pm
UUID: 5a7cd867-c35a-bf4a-9f21-4f51eae8b612
Ancestors: Morphic-ul.1780

Don't raise an error when pressing a key while focusing an empty scroll bar (such as the main panel in a freshly opened preference browser).

=============== Diff against Morphic-ul.1780 ===============

Item was changed:
----- Method: ScrollPane>>keyStroke: (in category 'event handling') -----
keyStroke: evt
"If pane is not empty, pass the event to the last submorph,
 assuming it is the most appropriate recipient (!!)"

+ scroller hasSubmorphs ifTrue:
+ [scroller lastSubmorph keyStroke: evt].!
- scroller submorphs last keyStroke: evt!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211020/d19e6fcb/attachment.html>

More information about the Squeak-dev mailing list