[squeak-dev] The Inbox: Tests-ct.466.mcz
Levente Uzonyi
leves at caesar.elte.hu
Fri Oct 22 14:44:54 UTC 2021
Hi Christoph,
On Fri, 22 Oct 2021, Thiede, Christoph wrote:
> ==================== Summary ====================
>
> Name: Tests-ct.466
> Author: ct
> Time: 22 October 2021, 3:28:55.369526 pm
> UUID: 359b8eb8-e155-4448-8039-42ef17ccb09d
> Ancestors: Tests-eem.464
>
> Provides regression tests for an issue with background styling in Shout that is fixed in ShoutCore-ct.86.
Is there a way for a human to trigger that issue without
explicitly mangling the deferred UI messages?
> + SystemOrganization addCategory: #'Tests-ShoutCore-Styling'!
Shout's tests live in a separate package: ShoutTests. Is there a reason to
add the these tests to the Tests package instead?
> Item was added:
> + ----- Method: ShoutBackgroundStylingTest>>runDeferredUIMessages (in category 'support') -----
> + runDeferredUIMessages
> +
> + self assert: Smalltalk isMorphic.
> +
> + [Project current lastDeferredUIMessage]
> + whileNotNil: [Project current world runStepMethods].!
Instead of introducing senders of never-used methods into the Trunk,
I suggest deprecating them and use "common" Smalltalk instead:
[Project current lastDeferredUIMessage isNil]
whileFalse: [Project current world runStepMethods]
> Item was added:
> + ----- Method: ShoutBackgroundStylingTest>>waitForDeferredUIMessages (in category 'support') -----
> + waitForDeferredUIMessages
> +
> + [Project current lastDeferredUIMessage]
> + whileNil: [10 milliSeconds wait].!
Same as above.
Levente
More information about the Squeak-dev
mailing list
|