[squeak-dev] The Inbox: ToolBuilder-Morphic-ct.279.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Oct 26 18:17:00 UTC 2021

A new version of ToolBuilder-Morphic was added to project The Inbox:

==================== Summary ====================

Name: ToolBuilder-Morphic-ct.279
Author: ct
Time: 26 October 2021, 8:16:58.339896 pm
UUID: 89094112-17a7-a848-85b0-060ddacdddd7
Ancestors: ToolBuilder-Morphic-mt.277

In PluggableTreeMorph, always compare tree items using #= rather than #==. This aligns the behavior to #selectPath:in:, which is never and already uses #=. Clients can decide theirselves how to compare items. Required for ToolBuilder-Morphic-ct.280.

For the ongoing discussion, see: http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-October/thread.html#:~:text=Item%20equality%20in%20PluggableTreeMorph

=============== Diff against ToolBuilder-Morphic-mt.277 ===============

Item was changed:
  ----- Method: PluggableTreeMorph>>getCurrentSelectionItem (in category 'selection') -----
  	"Our models are supposed to return real objects, not wrappers. See PluggableTreeItemNode."
  	| selectedObject |
  	selectedObject := self getSelectedSelector
  		ifNil: [^ nil]
  		ifNotNil: [:symbol | model perform: symbol].
  	^ scroller submorphs
+ 		detect: [:each | each complexContents item = selectedObject]
- 		detect: [:each | each complexContents item == selectedObject]
  		ifFound: [:each | each complexContents]
  		ifNone: [nil]!

Item was changed:
  ----- Method: PluggableTreeMorph>>updateFromChangedObject: (in category 'updating') -----
  updateFromChangedObject: anObject
  	scroller submorphs
+ 		detect: [:morph | morph complexContents item = anObject]
- 		detect: [:morph | morph complexContents item == anObject]
  		ifFound: [:morph | self updateMorph: morph]
  		ifNone: ["Ignore the request. Object may not be visible anyway."].!

More information about the Squeak-dev mailing list