[squeak-dev] The Trunk: EToys-ul.448.mcz
Thiede, Christoph
Christoph.Thiede at student.hpi.uni-potsdam.de
Fri Sep 3 23:29:32 UTC 2021
Hi Levente,
I'm very much with you that we should get rid of #ifNotNilDo:, but unless we actually deprecate this selector, I fear that this is an unstable change which someone else might revert in any later commit out of ignorance. Do we want to deprecate #ifNotNilDo: & Co. before the next major release? :-)
Best,
Christoph
________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Freitag, 3. September 2021 16:22:05
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: EToys-ul.448.mcz
Levente Uzonyi uploaded a new version of EToys to project The Trunk:
http://source.squeak.org/trunk/EToys-ul.448.mcz
==================== Summary ====================
Name: EToys-ul.448
Author: ul
Time: 3 September 2021, 3:50:47.825369 pm
UUID: 32822614-0663-4add-b1f3-cbbf4c906a6d
Ancestors: EToys-nice.447
- ifNotNilDo: -> ifNotNil:
=============== Diff against EToys-nice.447 ===============
Item was changed:
----- Method: ScriptEditorMorph>>dismiss (in category 'buttons') -----
dismiss
"Dismiss the scriptor, usually nondestructively. Possibly animate the dismissal."
| endPoint aForm startPoint topRend |
owner ifNil: [^ self].
scriptName ifNil: [^ self delete]. "ad hoc fixup for bkwrd compat"
+ endPoint := self viewerTile ifNotNil: [:tile | tile topLeft] ifNil: [owner topRight].
- endPoint := self viewerTile ifNotNilDo: [:tile | tile topLeft] ifNil: [owner topRight].
aForm := (topRend := self topRendererOrSelf) imageForm offset: (0 at 0).
handWithTile := nil.
startPoint := topRend topLeft.
topRend topRendererOrSelf delete.
(playerScripted isExpendableScript: scriptName) ifTrue: [
^ playerScripted removeScript: scriptName fromWorld: Project current world].
Project current world displayWorld.
aForm slideFrom: startPoint to: endPoint nSteps: 4 delay: 30.
"The OLPC Virtual Screen wouldn't notice the last update here."
Display forceToScreen: (endPoint extent: aForm extent).!
Item was changed:
----- Method: TileMorph>>layoutChanged (in category 'layout') -----
layoutChanged
| vpanel hpanel popArrows |
super layoutChanged.
self labelMorph
ifNil: [^ self].
+ popArrows := self activeHand ifNil: [^ self] ifNotNil: [:ac |
- popArrows := self activeHand ifNil: [^ self] ifNotNilDo: [:ac |
ac valueOfProperty: #popArrows
ifAbsent: [^ self]].
popArrows first == self
ifFalse: [^ self].
vpanel := popArrows second.
hpanel := popArrows third.
vpanel
ifNotNil: [vpanel openInWorld.
vpanel center: self labelMorph center.
vpanel right: self labelMorph left - 2].
hpanel
ifNotNil: [hpanel openInWorld.
hpanel center: self labelMorph center.
hpanel left: self labelMorph right + 2]!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20210903/bc520dee/attachment.html>
More information about the Squeak-dev
mailing list
|