[squeak-dev] The Trunk: MorphicTests-lrnp.83.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Apr 5 12:19:30 UTC 2022

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk:

==================== Summary ====================

Name: MorphicTests-lrnp.83
Author: lrnp
Time: 29 March 2022, 10:37:07.821731 pm
UUID: 4be0f980-b341-4fd3-80ac-9d187d1caf7d
Ancestors: MorphicTests-ct.82

handle preferences that alter test results

Turn off Always Show V Scrollbar. This causes many tests to fail when turned on.

Use the preference-friendly #lineGridForMorphs method instead of #height. There are two font heights based on the Use Compact Lists preference; this method picks the correct one.

=============== Diff against MorphicTests-ct.82 ===============

Item was changed:
  ----- Method: TableLayoutTest>>setUp (in category 'running') -----
  	super setUp.
  	reset := {
  		([:enable | [self useRetractableScrollBars: enable]]
+ 			value: self useRetractableScrollBars).
+ 		([:previous | [Preferences setFlag: #alwaysShowVScrollbar toValue: previous]]
+ 			value: (Preferences valueOfFlag: #alwaysShowVScrollbar))
- 			value: self useRetractableScrollBars)
+ 	self useRetractableScrollBars: false.
+ 	Preferences setFlag: #alwaysShowVScrollbar toValue: false.!
- 	self useRetractableScrollBars: false!

Item was changed:
  ----- Method: TableLayoutTest>>testBrowser (in category 'tests - example layouts') -----
  	" replicate the layout used by the system browser with a table layout "
  	| buttons |
  	buttons := #('browse' 'senders' 'implementors' 'versions' 'inheritance' 'hierarchy' 'vars' 'source') collect: [:label |
  		self newMorph
  			hResizing: #spaceFill;
  			vResizing: #shrinkWrap;
  			wrapCentering: #center;
  			layoutPolicy: TableLayout new;
  			layoutInset: 8;
  			addMorph: (StringMorph new contents: label)].
  	container := self newContainer
  		listDirection: #topToBottom;
  		layoutInset: 8;
  		cellGap: 8;
  		addMorphBack: (self newContainer
  			cellGap: 8;
  			listDirection: #leftToRight;
  			hResizing: #spaceFill;
  			vResizing: #spaceFill;
  			minimumHeight: 30;
  			addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill);
  			addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill);
  			addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill);
  			addMorphBack: (self newMorph hResizing: #spaceFill; vResizing: #spaceFill));
  		addMorphBack: (self newContainer
  			vResizing: #shrinkWrap;
  			hResizing: #spaceFill;
  			cellGap: 2;
  			addAllMorphsBack: buttons);
  		addMorphBack: (self newMorph
  			minimumHeight: 100;
  			hResizing: #spaceFill;
  			vResizing: #spaceFill).
  	container extent: 0 @ 0.
  	"container openInHand."
  	self ensureLayout: container.
+ 	self assert: 100 + 30 + self defaultFont lineGridForMorphs + (8 * 6) equals: container height!
- 	self assert: 100 + 30 + self defaultFont height + (8 * 6) equals: container height!

More information about the Squeak-dev mailing list