> What do you think, should we establish that? :-)

Maybe not. It is kind of performance critical. Leave it be. For now. :-)

Best,
Marcel
Am 07.04.2022 15:52:38 schrieb christoph.thiede at student.hpi.uni-potsdam.de <christoph.thiede at student.hpi.uni-potsdam.de>:
> Nice catch! I actually assumed that the styler resets its state before calling into the model. :-O

What do you think, should we establish that? :-)

Best,
Christoph

---
Sent from Squeak Inbox Talk [https://github.com/hpi-swa-lab/squeak-inbox-talk]

On 2021-12-16T11:15:17+01:00, marcel.taeumel at hpi.de wrote:

> Nice catch! I actually assumed that the styler resets its state before calling into the model. :-O
>
> Best,
> Marcel
> Am 15.12.2021 20:01:36 schrieb commits at source.squeak.org <commits at source.squeak.org>:
> Christoph Thiede uploaded a new version of Tools to project The Trunk:
> http://source.squeak.org/trunk/Tools-ct.1091.mcz
>
> ==================== Summary ====================
>
> Name: Tools-ct.1091
> Author: ct
> Time: 15 December 2021, 8:01:22.087022 pm
> UUID: 5b6f6413-b247-5642-8890-68b2ccfacbdc
> Ancestors: Tools-ct.1089
>
> Fixes a slip introduced with BlockClosureInspector. Make sure to reset the styler's workspace variable after switching to a different kind of inspector (i.e., in the context of a debugger). Otherwise, you might see error messages such as "MessageNotUnderstood: Inspector>>hasBindingOf:". :-)
>
> =============== Diff against Tools-ct.1089 ===============
>
> Item was changed:
> ----- Method: Inspector>>updateStyler:requestor: (in category 'user interface - styling') -----
> updateStyler: aStyler requestor: anObject
> "Use this method to update our fieldListStyler and all view stylers."
>
> aStyler
> environment: self environment;
> classOrMetaClass: (self doItReceiver perform: #class "do not inline send of #class, receiver could be a proxy");
> context: self doItContext;
> + parseAMethod: false;
> + workspace: nil "Normally we don't need this, but probably a workspace has been specified when the receiver was belonging to another class. See #inspect: and BlockClosureInspector >> #updateStyler:requestor:.".!
> - parseAMethod: false.!
>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211216/192a2c30/attachment.html>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220407/0e66224f/attachment.html>