[squeak-dev] The Trunk: Graphics-mt.508.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Apr 16 09:05:26 UTC 2022

Marcel Taeumel uploaded a new version of Graphics to project The Trunk:

==================== Summary ====================

Name: Graphics-mt.508
Author: mt
Time: 16 April 2022, 11:05:19.443926 am
UUID: 9f4018fb-a23b-fc40-91d5-12e671969856
Ancestors: Graphics-mt.507

On macOS platforms, do not scale up hardware cursor in the image since the OSVM platform code cannot (yet) tell the OS to not do it itself.

=============== Diff against Graphics-mt.507 ===============

Item was changed:
  ----- Method: Cursor class>>currentCursor: (in category 'current cursor') -----
  currentCursor: aCursor 
  	"Make the instance of cursor, aCursor, be the current cursor. Display it. 
  	Create an error if the argument is not a Cursor."
  	(aCursor isKindOf: self)
  		ifTrue: [ | platformCursor |
  			CurrentCursor := aCursor. "unscaled"
+ 			platformCursor := aCursor scaleIconToDisplay.
- 			platformCursor := aCursor enlargedBy: (RealEstateAgent scaleFactor max: 1).
  			self useBiggerCursors
  				ifTrue: [platformCursor := platformCursor enlargedBy: 2].
  			platformCursor beCursor]
  		ifFalse: [self error: 'The new cursor must be an instance of class Cursor']!

Item was added:
+ ----- Method: Cursor>>scaleIconToDisplay (in category 'converting') -----
+ scaleIconToDisplay
+ 	"Overwritten to use the custom #enlargedBy: method to scale up the receiver."
+ 	self flag: #todo. "mt: The current OSVM platform code for macOS has an issue with *not* scaling up hardware cursors for Retina displays. So we avoid scaling it here and let the OS do it. Note that this is not good because we could never provide a high-resolution cursor from within Squeak since the OS would scale it up anyway."
+ 	Smalltalk platformName = 'Mac OS' ifTrue: [^ self].
+ 	^ self enlargedBy: (RealEstateAgent scaleFactor max: 1)!

More information about the Squeak-dev mailing list