[squeak-dev] The Inbox: Tools-lrnp.1144.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Wed Apr 27 14:22:30 UTC 2022

Hi Lauren --


Now we get "Chronology-nil" as #selectedSystemCategory when one selects the "Chronology" package but no category. The old answer was "nil" instead of "Chronology-nil".

Am 28.03.2022 22:14:30 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of Tools was added to project The Inbox:

==================== Summary ====================

Name: Tools-lrnp.1144
Author: lrnp
Time: 28 March 2022, 2:14:18.999919 pm
UUID: 93cebbab-cdc7-4e8d-97c7-f8e7a099c4da
Ancestors: Tools-mt.1143

remove unneeded method in PackagePaneBrowser

Browser>>selectedSystemCategory is defined to return nil when nothing is selected, so remove the test in PackagePaneBrowser's version. Removing the test lets us remove the other method entirely.

PackagePaneBrowser>>hasSystemCategorySelected was only needed to avoid infinite recursion.

=============== Diff against Tools-mt.1143 ===============

Item was removed:
- ----- Method: PackagePaneBrowser>>hasSystemCategorySelected (in category 'system category list') -----
- hasSystemCategorySelected
- ^ super selectedSystemCategory notNil.!

Item was changed:
----- Method: PackagePaneBrowser>>selectedSystemCategory (in category 'system category list') -----
"Answer the name of the selected system category or nil."

- self hasSystemCategorySelected
- ifFalse: [^nil].
packageListIndex = 0
ifTrue: [^ super selectedSystemCategory ].
^ self package , '-' , super selectedSystemCategory!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220427/352f285c/attachment.html>

More information about the Squeak-dev mailing list