Hi Lauren --

-1

This introduces a performance regression. The idea behind #installLineEndConvention: is to map Character cr (i.e. Squeak's internal line ending) to whatever you need. That's why it reads "latin1Encodings at: 14".

I am not sure why your changes in MultilingualTests-lrnp.44 would not pass without this.

Best,
Marcel
Am 23.04.2022 23:09:43 schrieb commits at source.squeak.org <commits at source.squeak.org>:
A new version of Multilingual was added to project The Inbox:
http://source.squeak.org/inbox/Multilingual-lrnp.282.mcz

==================== Summary ====================

Name: Multilingual-lrnp.282
Author: lrnp
Time: 23 April 2022, 3:09:21.948922 pm
UUID: 3a55887e-1dcc-49ee-8e3b-f1529f94852c
Ancestors: Multilingual-mt.281

pass MultilingualTests-lrnp.44

Fixes issue on Mac where opening a File List raises an error.

=============== Diff against Multilingual-mt.281 ===============

Item was changed:
----- Method: UTF8TextConverter>>encodeString: (in category 'conversion') -----
encodeString: aString

| result |
aString isByteString ifFalse: [ ^super encodeString: aString ].
result := self class encodeByteString: aString.
+ self class latin1Encodings = latin1Encodings ifTrue: [ ^result ].
- self class latin1Encodings == latin1Encodings ifTrue: [ ^result ].
^result withLineEndings: (latin1Encodings at: 14)
!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220427/2fca6a32/attachment.html>