[squeak-dev] A lot of shadowed variable names in Squeak 6.0 needing clearing up

tim Rowledge tim at rowledge.org
Mon Dec 26 06:10:44 UTC 2022


Marking some that need more attention -

> MenuMorph>>invokeModalAt:in:allowKeyboard: (originalFocusHolder is shadowed)
> MenuMorph>>invokeAt:in:allowKeyboard: (originalFocusHolder is shadowed)
Simple change in the two above appears to work but focus issues are always interesting

> SketchEditorMorph>>initializeFor:inBounds:pasteUpMorph: (palette is shadowed)
> BookMorph>>insertPageColored: (borderWidth is shadowed)
Needs testing by someone used to using the BookMorph

> ObjectsTool>>highlightOnlySubmorph:in: (color is shadowed)
> MCMethodDefinition>>printAnnotations:on: (timeStamp is shadowed)
> PluggableListMorph>>getFilteredList (fullList is shadowed)
> Parser>>collectTemporaryDeclarationsFrom: (mark is shadowed)
May be more subtle than I could spot

> TextAnchorTest>>testResizeAnchoredMorph (anchoredMorph is shadowed)
> SpaceTally>>spaceForInstance:depth:seen: (depth is shadowed)
> BorderedMorph>>doFastWindowReframe: (owner is shadowed)
> SoundService class>>defaultOrNil (default is shadowed)
> MCClassDefinition>>createClass (traitComposition is shadowed)
> ClassInspector>>streamSharedPoolsOn: (object is shadowed)
> ClassInspector>>streamClassVariablesOn: (object is shadowed)
> Project class>>makeANewLocalGallery (name is shadowed)
> Project class>>cleanUpEtoysGarbage (name is shadowed)
> ProcessTest>>testResumeTerminatingProcess (semaphore is shadowed)
> ProcessTest>>testTerminateTerminatingProcess (semaphore is shadowed)
> Context>>directedSuperSend:numArgs: (receiver is shadowed)
Definitely needs second check

> TestRunner>>findClassesForCategories: (environment is shadowed)

This is as far as I've got today

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Oxymorons: Advanced BASIC




More information about the Squeak-dev mailing list