Thank you! I wanted to pass objects into the #chooseFrom: recently and was disappointed that this apparently was not supported ... Glad it works again! :-)


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 3. Februar 2022 17:14:02
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: ToolBuilder-Morphic-mt.292.mcz

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.292.mcz

==================== Summary ====================

Name: ToolBuilder-Morphic-mt.292
Author: mt
Time: 3 February 2022, 5:14:01.689252 pm
UUID: 9e44876c-0f30-4844-a9fe-55f0c4faae18
Ancestors: ToolBuilder-Morphic-mt.291

Fixes regression in list-chooser dialogs, which are not only for lists of strings but actual objects.

Thanks to David O'Toole for reporting this!

=============== Diff against ToolBuilder-Morphic-mt.291 ===============

Item was changed:
  ----- Method: ListChooser>>initialExtent (in category 'building') -----
  initialExtent

         | listFont itemCount maxItemSize cellSize |
         listFont := Preferences standardListFont.
         itemCount := items size.
+        maxItemSize := items inject: 0 into: [:max :item | max max: item asString size].
-        maxItemSize := items inject: 0 into: [:max :item | max max: item size].
         cellSize := (listFont widthOf: $m) @ listFont height.

         ^ ((maxItemSize min: 20 max: 10)
                 @ (itemCount min: 15 max: 5)
                 * cellSize) + (0@ self searchBarHeight)!

Item was changed:
  ----- Method: ListMultipleChooser>>initialExtent (in category 'toolbuilder') -----
  initialExtent

         | listFont itemCount maxItemSize cellSize |
         listFont := Preferences standardListFont.
         itemCount := labels size.
+        maxItemSize := labels inject: 0 into: [:max :item | max max: item asString size].
-        maxItemSize := labels inject: 0 into: [:max :item | max max: item size].
         cellSize := (listFont widthOf: $m) @ listFont height.

         ^ ((maxItemSize min: 20 max: 10)
                 @ (itemCount min: 15 max: 5)
                 * cellSize)!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220206/95672a85/attachment.html>