[squeak-dev] The Trunk: Morphic-mt.1913.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Feb 28 10:19:38 UTC 2022

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-mt.1913
Author: mt
Time: 28 February 2022, 11:19:33.058532 am
UUID: a6a11681-f9b0-4ab7-9da6-a8411611639a
Ancestors: Morphic-mt.1912

Fixes a regression in text-cursor (i.e. caret) visibility. It is now visible again during type-in, not blinking.

I removed the extra #hasFocus check in the caret's display routines. Now we notice some inconsistency in caret management when building new paragraphs. There are still some extra carets visible after tool construction I have to figure out. It might be related to unnecessary editor instances...

=============== Diff against Morphic-mt.1912 ===============

Item was changed:
  ----- Method: NewParagraph>>showCaret (in category 'access') -----
+ 	^showCaret ifNil:[true]
- 	^showCaret ifNil:[false]

Item was changed:
  ----- Method: TextMorph>>createParagraph (in category 'private') -----
  	self setProperty: #CreatingParagraph toValue: true.
  		self setDefaultContentsIfNil.
  		"...Code here to recreate the paragraph..."
  		paragraph := (self paragraphClass new textOwner: self owner).
  		paragraph wantsColumnBreaks: successor notNil.
  			compose: text
  			style: textStyle
  			from: self startingIndex
  			in: self container.
  		wrapFlag ifFalse:
  			["Was given huge container at first... now adjust"
  			paragraph adjustRightX].
  		paragraph focused: (self currentHand keyboardFocus == self).
+ 			showCaret: self hasFocus;
  			caretColor: self caretColor;
  			selectionColor: self selectionColor;
  			unfocusedSelectionColor: self unfocusedSelectionColor.
  		self fit.
  	] ensure: [self removeProperty: #CreatingParagraph].
  	^ paragraph!

More information about the Squeak-dev mailing list