[squeak-dev] The Trunk: Morphic-mt.1913.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Mon Feb 28 15:14:08 UTC 2022

PS: Maybe this regression was also caused by Morphic-mt.1912.

Von: Thiede, Christoph
Gesendet: Montag, 28. Februar 2022 16:12:33
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: AW: [squeak-dev] The Trunk: Morphic-mt.1913.mcz

Hi Marcel,

when I open three workspaces in a fresh Trunk image now, each of them will have and keep a caret. This is surely a regression, isn't it? :-)




Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Montag, 28. Februar 2022 11:19:38
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Morphic-mt.1913.mcz

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:

==================== Summary ====================

Name: Morphic-mt.1913
Author: mt
Time: 28 February 2022, 11:19:33.058532 am
UUID: a6a11681-f9b0-4ab7-9da6-a8411611639a
Ancestors: Morphic-mt.1912

Fixes a regression in text-cursor (i.e. caret) visibility. It is now visible again during type-in, not blinking.

I removed the extra #hasFocus check in the caret's display routines. Now we notice some inconsistency in caret management when building new paragraphs. There are still some extra carets visible after tool construction I have to figure out. It might be related to unnecessary editor instances...

=============== Diff against Morphic-mt.1912 ===============

Item was changed:
  ----- Method: NewParagraph>>showCaret (in category 'access') -----
+        ^showCaret ifNil:[true]
-        ^showCaret ifNil:[false]

Item was changed:
  ----- Method: TextMorph>>createParagraph (in category 'private') -----

         self setProperty: #CreatingParagraph toValue: true.

                 self setDefaultContentsIfNil.

                 "...Code here to recreate the paragraph..."
                 paragraph := (self paragraphClass new textOwner: self owner).
                 paragraph wantsColumnBreaks: successor notNil.
                         compose: text
                         style: textStyle
                         from: self startingIndex
                         in: self container.
                 wrapFlag ifFalse:
                         ["Was given huge container at first... now adjust"
                         paragraph adjustRightX].
                 paragraph focused: (self currentHand keyboardFocus == self).

+                        showCaret: self hasFocus;
                         caretColor: self caretColor;
                         selectionColor: self selectionColor;
                         unfocusedSelectionColor: self unfocusedSelectionColor.

                 self fit.
         ] ensure: [self removeProperty: #CreatingParagraph].

         ^ paragraph!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220228/f2cf05f3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 43704 bytes
Desc: pastedImage.png
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220228/f2cf05f3/attachment.png>

More information about the Squeak-dev mailing list