[squeak-dev] The Trunk: Monticello-ct.729.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Tue Jan 11 12:34:40 UTC 2022

Hi Christoph --

> I would have expected

Then my comparison with Markdown seems to have mislead you. Sorry. Don't overthink it. It's just a low-hanging fruit. It's way simpler than starting to implement hide/show capabilities in ProportionalLayout ;-) 

Am 11.01.2022 13:26:59 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi Marcel,

Markdown sounds *very* appealing, but my personal preference would be to think through this thoroughly rather than starting with a single syntax for a rather special use case. For instance, I would have expected `- ' to map to a (not yet existing) EnumerationAttribute with an indented bullet point (•). I would prefer to collect more use cases before going into the implementation of such an API. Just my 2 cents. :-)

Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 11. Januar 2022 13:13:46
An: squeak-dev
Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.729.mcz
Hi all --

If you want to, we can add a very simple portion of Markdown to parse it into a list morph in the dialog. Just match for hyphens at the beginning of two or more lines:

- This
- is
- a
- list

The dialog could show 3 lines by default and the rest via scrolling. Is this too much magic?

Am 10.01.2022 13:12:08 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
Hi all,

these are nested strings via #format:. :-) The message actually looks like this:

Do you have any other change requests to the message? :-)

Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von tim Rowledge <tim at rowledge.org>
Gesendet: Montag, 10. Januar 2022 05:42:26
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.729.mcz
I agree with Chris here; though the split handling of the 1/more versions is nice.

As for the version name truncation, a nicer solution would be for the notifier UI to have a scrollbar if is it needed. And while fantasising, if there is more than one version to report using a UI list would be nice, especially since it would provide for a scrollbar in the eventuality that many items need listing.

> On 2022-01-09, at 5:25 PM, Chris Muller <asqueaker at gmail.com> wrote:
> -1
> Seeing, "Caution, do you really want to...," is kind of annoying because it's applying the "caution" to the user's intent BEFORE saying why. 
> The old message applied the caution to the REASON, and THEN asked the user, "do you really want to...".
> From that aspect, the old message is better.
> On Mon, Jan 3, 2022 at 2:41 PM <commits at source.squeak.org> wrote:
> Christoph Thiede uploaded a new version of Monticello to project The Trunk:
> http://source.squeak.org/trunk/Monticello-ct.729.mcz [http://source.squeak.org/trunk/Monticello-ct.729.mcz]
> ==================== Summary ====================
> Name: Monticello-ct.729
> Author: ct
> Time: 17 September 2020, 7:04:53.385813 pm
> UUID: 5eea47cc-405e-7841-9544-0f57a9b92fa0
> Ancestors: Monticello-cmm.726
> Proposal: Enhance truncation of "newer versions avaiable" warning (and make it multilingual-ready)
> =============== Diff against Monticello-cmm.726 ===============
> Item was changed:
>   ----- Method: MCWorkingCopyBrowser>>checkForNewerVersions (in category 'actions') -----
>   checkForNewerVersions
> +       "Answer true if there are no newer versions preventing us from saving a version."
> +
>         | newer |
>         newer := workingCopy possiblyNewerVersionsIn: self repository.
> +      
> +       newer ifEmpty: [^ true].
> +      
> +       ^ self confirm: ('CAUTION!! {1}:\{2}\Do you really want to save this version?' withCRs translated format: {
> +               newer size = 1
> +                       ifTrue: ['This version in the repository may be newer' translated]
> +                       ifFalse: ['These {1} versions in the repository may be newer' translated format: {newer size}].
> +               (newer size > 3
> +                       ifFalse: [newer]
> +                       ifTrue: [(newer first: 3) , {'...'} , {newer last}]) asCommaString withNoLineLongerThan: 150
> +       })!
> -       ^ newer isEmpty or: [
> -               self confirm: 'CAUTION!! These versions in the repository may be newer:',
> -                       String cr, ((newer asCommaString withNoLineLongerThan:  150) truncateWithElipsisTo: 5 * 149), String cr,
> -                       'Do you really want to save this version?'].!

tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim [http://www.rowledge.org/tim]
Design simplicity: It was developed on a shoe-string budget.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220111/c4885b58/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 13852 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220111/c4885b58/attachment-0001.png>

More information about the Squeak-dev mailing list