[squeak-dev] The Inbox: ToolBuilder-Morphic-cmm.285.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Thu Jan 13 09:11:09 UTC 2022

Hi Chris --

Fixed in System-mt.1282. Please test via "UserInterfaceTheme cleanUpAndReset". If it looks as expected, we can add an entry to the update map.

Am 13.01.2022 09:57:22 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Hi Chris --

It looks like the affected UI themes are:
- Community (dark)
- Solarized (light)
- Solarized (dark)

I am not sure that we can do anything for the Solarized themes because those are low-contrast by definition. But we surely can fix the Community theme.

Am 13.01.2022 09:51:28 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Hi Chris --

I will look into this. Thanks for the report. :-) The fix will likely not be in PluggableTextMorphPlus but in the UI theme's property. Maybe a new one.

> I just wish it weren't so prominent.

Beware of different monitors. There are several displays out there that cannot show gray scales that accurate. Making it too vague would render it invisible on those monitors. Yet, I am sure that we can improve it a little bit more.

Am 13.01.2022 07:20:33 schrieb Chris Muller <asqueaker at gmail.com>:
Hi Marcel, hi all,

As a user-friendly UI feature, I really like the field help in the backgrounds of text fields, however I continue to find its intensity distracting.  It seems like it should just be a "whisper" of a hint, very light in the background.  The way it is, it sometimes looks as if it were actually the entered value.

I tried to set the color to a lower alpha value to accomplish this, but it didn't seem to have any effect at all on the color (until I reached < 0.01, at which point it disappeared entirely).

If text cannot be rendered there with a lower opacity, it could at least match the #comment color of the selected theme.  It essentially serves the same purpose as a comment.  In the Community Dark theme, that color is quite subtle, so it works.

I like the feature, I really don't want to turn off the preference, I just wish it weren't so prominent.  Would love your hear your thoughts.

 - Chris

On Thu, Jan 13, 2022 at 12:06 AM <commits at source.squeak.org [mailto:commits at source.squeak.org]> wrote:

Chris Muller uploaded a new version of ToolBuilder-Morphic to project The Inbox:
http://source.squeak.org/inbox/ToolBuilder-Morphic-cmm.285.mcz [http://source.squeak.org/inbox/ToolBuilder-Morphic-cmm.285.mcz]

==================== Summary ====================

Name: ToolBuilder-Morphic-cmm.285
Author: cmm
Time: 13 January 2022, 12:06:18.53413 am
UUID: fdfc0020-4e12-4f5c-a2bc-f632794ce0c3
Ancestors: ToolBuilder-Morphic-mt.284

Render field help text in the color used for comments.

=============== Diff against ToolBuilder-Morphic-mt.284 ===============

Item was changed:
  ----- Method: PluggableTextMorphPlus>>drawBalloonTextOn: (in category 'drawing') -----
  drawBalloonTextOn: aCanvas
        "Show balloon text in the text morph if it has no contents."
        textMorph contents ifNotEmpty: [ ^ self ].
        ([ self balloonText ]
                on: Error
                do: [ : err | 'error in balloonText' ]) ifNotNil:
                [ : text | aCanvas
                        drawString: text
                        in: (self innerBounds insetBy: (5 @ 2 corner: 0 @ 0))
                        font: (self userInterfaceTheme balloonTextFont ifNil: [TextStyle defaultFont])
+                       color: ((self userInterfaceTheme get: #comment for: SHTextStylerST80) first ifNil: [Color gray darker]) ]!
-                       color: (self userInterfaceTheme balloonTextColor ifNil: [Color gray: 0.7]) ]!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220113/e696ce0c/attachment.html>

More information about the Squeak-dev mailing list