Hi Christoph --

You are showing the "more..." menu. The initial menu is truncated because of that bug in #isBreakOnEntry.



After Eliot's patch, it looks as expected:



Best,
Marcel
Am 13.01.2022 19:26:32 schrieb Thiede, Christoph <christoph.thiede at student.hpi.uni-potsdam.de>:
I have a message trace here with no message selected, but the menu can be opened anyway without an error:


 


Under which circumstances did this error occur? :-)

Best,
Christoph
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von commits at source.squeak.org <commits at source.squeak.org>
Gesendet: Donnerstag, 13. Januar 2022 19:21:13
An: squeak-dev at lists.squeakfoundation.org; packages at lists.squeakfoundation.org
Betreff: [squeak-dev] The Trunk: Tools-eem.1104.mcz
 
Eliot Miranda uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-eem.1104.mcz [http://source.squeak.org/trunk/Tools-eem.1104.mcz]

==================== Summary ====================

Name: Tools-eem.1104
Author: eem
Time: 13 January 2022, 10:21:10.513361 am
UUID: 1d051d8d-473d-43ee-9628-d33992a5849f
Ancestors: Tools-mt.1103

Fix MNU in menu building for MessageTrace with no method selected

=============== Diff against Tools-mt.1103 ===============

Item was changed:
  ----- Method: CodeHolder>>isBreakOnEntry (in category 'breakpoints') -----
  isBreakOnEntry
 
+        ^self selectedClassOrMetaClass
+                ifNil: [false]
+                ifNotNil:
+                        [:class|
+                         (class
+                                        compiledMethodAt: self selectedMessageName
+                                        ifAbsent: nil)
+                                ifNil: [false]
+                                ifNotNil: [:method| method hasBreakpoint]]!
-        | selectedMethod |
-        selectedMethod := self selectedClassOrMetaClass
-                compiledMethodAt: self selectedMessageName
-                ifAbsent: [^ false].
-        ^ selectedMethod hasBreakpoint!


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 22635 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 4074 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 18275 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pastedImage.png
Type: image/png
Size: 15326 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 78379 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/a8d504cb/attachment-0009.png>