[squeak-dev] bad MessageTrace regression (was: The Trunk: Morphic-mt.1652.mcz)

Marcel Taeumel marcel.taeumel at hpi.de
Fri Jan 14 09:53:45 UTC 2022

Okay, here is something constructive. :-)

You can invoke senders/implementors in MessageTrace as follows:

(m1) Menu in message list, which considers the current message (selector)
(m2) Keyboard shortcut in message list, which considers the current message (selector)
(c1) Menu in code pade, which considers the current text selection
(c2) Keyboard shortcut in code pane, which considers the current text selection
(b) Click on the senders/implementors button between code pane and message list, which considers the current message (selector) but lets the user choose from a list of all other selectors in that message/method

Currently, (m1) and (m2) modify the trace while (c1) and (c2) and (b) open an new window. What should change?


P.S.: Before my recent change, (m1), (m2), (c1), and (c2) modified the trace while only (b) opened a new window. Then Chris called that a regression. ;-)
Am 14.01.2022 10:25:01 schrieb Marcel Taeumel <marcel.taeumel at hpi.de>:
Huh? You guys are really entertaining me right now ... What exactly do you want here?

Chris wrote:
>  When selecting a message in the code pane and browsing senders, **it must always spawn a new MessageTrace** instead of mangling the to the list at the top.

So, I select a piece of text in the code pane and then hit CMD+N (being focused in the code pane)? Or that "senders" button? Or what?

Seriously ... This is not funny! Please try to be more clear. Provide screenshots.

Am 14.01.2022 05:37:02 schrieb Chris Muller <asqueaker at gmail.com>:
Jakob and Christoph are right. Browsing Implementors from the code
pane must continue the trace in the upper pane. I took a quick
look, but a proper fix in line with Marcel's intentions for the code
design wasn't 100% clear, so I refrained for now. Christoph's
temporary solution works in the meantime.

On Thu, Jan 13, 2022 at 2:42 PM Thiede, Christoph
> Hi all,
> I am experiencing the same regression. IMHO it does not make any sense to honor the "trace messages" preference only in the message list, but not in the code pane. This preference has been working in the code pane even back in Squeak 5.2 and I would really appreciate gaining this behavior back. :-)
> For a fix patch, you can comment out the anObject = #modelMenu check in MessageTrace>>#browseAllImplementorsOf:requestor: and #browseAllCallsOn:requestor:.
> Best,
> Christoph
> ________________________________
> Von: Squeak-dev im Auftrag von Jakob Reschke
> Gesendet: Donnerstag, 13. Januar 2022 21:14:48
> An: The general-purpose Squeak developers list
> Betreff: Re: [squeak-dev] bad MessageTrace regression (was: The Trunk: Morphic-mt.1652.mcz)
> Hi Marcel,
> When I press Cmd-m in a MessageTrace now, I now get a new window, when previously the methods were added to the current window as subordinates of the selected method.
> From the message list, one can only expand the trace "upwards" because you only have the method's own selector in the list. But to expand "downwards" you must use the code editor to select messages that are being sent from the selected method.
> Kind regards,
> Jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220114/039e63ac/attachment.html>

More information about the Squeak-dev mailing list