[squeak-dev] Why not just get rid of the sources file entirely (was: The Inbox: System-dtl.1277.mcz)
David T. Lewis
lewis at mail.msen.com
Mon Jan 17 18:17:31 UTC 2022
Rather that putting a lot of effort into figuring out how to package
the sources file and how to locate sources files in various places
for various different operating systems, why don't we just get rid
of the file entirely?
Traditionally the sources file is delivered as a disk file separate
from the images file. That is good if you are dealing with small images
and VMs with limited address space, but nowadays our 64-bit release
image is over 50MB in size, and typical working images get much larger
than that. Meanwhile, a compressed sources file is only(!) 6.7MB on disk.
So rather than use files, just keep the sources in the image. It would
work like this:
- Load the compressed sources file into an object, hold it in a class var
- If the in-image sources exist, use them, otherwise use file based sources
- Allow the in-image sources to be cleared so that small images or images
transmitted over the network do not need to carry the sources along
- Existing disk-based sources lookup would work as before
I actually have this working now, and I am not seeing any problems when
using the in-image sources. The sources file never needs to be reopened
or located from the file system.
The attached png shows an explorer on the sources file array in my
image after changing over to the in-image compressed sources. The raw
compressed data is highlighted in the explorer.
If this sounds worthwhile, I'll clean it up a bit and post a change set
or inbox submission.
On Mon, Jan 17, 2022 at 12:56:01PM +0100, Marcel Taeumel wrote:
> Hi Dave --
> Did you double-check whether it is safe to remove that interface on FileDirectory class???
> Am 02.01.2022 09:42:09 schrieb David T. Lewis <lewis at mail.msen.com>:
> See discussion at:
> On Sat, Jan 01, 2022 at 08:47:18PM +0000, commits at source.squeak.org wrote:
> > A new version of System was added to project The Inbox:
> > http://source.squeak.org/inbox/System-dtl.1277.mcz
> > ==================== Summary ====================
> > Name: System-dtl.1277
> > Author: dtl
> > Time: 1 January 2022, 2:57:48.389886 pm
> > UUID: 4d975f20-d62d-4b7e-8abb-bc511d976834
> > Ancestors: System-mt.1276
> > Look for the sources file in well-known locations on some platforms. For Unix, if not found in the usual locations then look in /usr/share/squeak and /usr/local/share/squeak. Hooks for other platforms may be added to SmalltalkImage>>sourcesFilePaths.
> > Refactor to reduce duplication of logic in locateSourcesEntry and openSources:forImage: and to ensure that the full set of file paths is searched for stc compressed sources files prior to searching for regular sources files.
> > =============== Diff against System-mt.1276 ===============
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 53815 bytes
Desc: not available
More information about the Squeak-dev