[squeak-dev] The Trunk: System-mt.1018.mcz
Christoph.Thiede at student.hpi.uni-potsdam.de
Wed Jan 19 14:46:25 UTC 2022
> Then you have to set the author initials on startUp to any specific value. That's how our CI does it.
But that requires me to define custom code into the image. Just changing some state in beforehand is much simpler.
> Well, I think this behavior originates from the fact that sharing your image via USB stick (or mail or floppy disk^^) means that a different person would then be the author. So, you would not want to store the wrong initials by accident. I think this point is still valid when students just share images without caring too much about preferences stored within. So, this is also kind of a security issue but not as serious as sharing your passwords.
Hm, this sounds to me as if you wanted to automatically do a system-wide #cleanUp instead when the image has been moved. We also do not clean up the clipboard or anything else when an image move is detected, and as you mentioned, the clipboard could contain much more sensitive information. Also, the heuristic for detecting "different machine" is insufficient, just assume both persons would store there image directly in in the file tree root (C:\). The fact that we are connecting those two aspects (image path and author initials) with each other appears arbitrary to me. If we were consistent with this intention, I think we should do "Smalltalk cleanUp: false" in this place. Still, I dislike the idea of automatically resetting the image on start-up. I would consider it somehow contrary to the idea of an image in general, that is, preserve some state and reuse it at a later point in time.
Hm ... make it a preference? :)
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Mittwoch, 19. Januar 2022 10:36:03
Betreff: Re: [squeak-dev] The Trunk: System-mt.1018.mcz
Hi Christoph --
> I was trying to prepare an image that does not ask the user for any initials
Then you have to set the author initials on startUp to any specific value. That's how our CI does it.
> Is this really necessary? :-)
Well, I think this behavior originates from the fact that sharing your image via USB stick (or mail or floppy disk^^) means that a different person would then be the author. So, you would not want to store the wrong initials by accident. I think this point is still valid when students just share images without caring too much about preferences stored within. So, this is also kind of a security issue but not as serious as sharing your passwords.
Yes, it's still a good practice. Also, your scenario can easily be supported. Just set your preferred initials on startUp.
Am 19.01.2022 03:53:25 schrieb christoph.thiede at student.hpi.uni-potsdam.de <christoph.thiede at student.hpi.uni-potsdam.de>:
do we really need to reset the author initials when one opens the image under a different path? This just stroke me a bit when I was trying to prepare an image that does not ask the user for any initials, but the receiver was still told to enter them again.
Also, note that string comparison is not sufficient for comparing paths. For instance, there are multiple ways under Windows to express the same path (UNC paths, virtual drive letters, ...), or even the WSL path when I open the same image, without moving it, from WSL rather from Windows.
Last but not least, this is a really unexpected side effect and I only found this via a sender search.
Is this really necessary? :-)
Sent from Squeak Inbox Talk<https://github.com/hpi-swa-lab/squeak-inbox-talk>
On 2018-04-16T08:31:43+00:00, commits at source.squeak.org wrote:
> Marcel Taeumel uploaded a new version of System to project The Trunk:
> ==================== Summary ====================
> Name: System-mt.1018
> Author: mt
> Time: 16 April 2018, 10:31:28.239614 am
> UUID: e0350560-a5a5-5a40-b31b-d13f55162021
> Ancestors: System-mt.1017
> #setAuthorInitials: -> #authorInitials:
> =============== Diff against System-mt.1017 ===============
> Item was changed:
> ----- Method: SmalltalkImage>>openSourceFiles (in category 'sources, changes log') -----
> self imageName = LastImageName ifFalse:
> ["Reset the author initials to blank when the image gets moved"
> LastImageName := self imageName.
> + Utilities authorInitials: ''].
> - Utilities setAuthorInitials: ''].
> openSources: self sourcesName
> andChanges: self changesName
> forImage: LastImageName.
> SourceFileArray install!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev