[squeak-dev] The Trunk: Morphic-mt.2004.mcz

Marcel Taeumel marcel.taeumel at hpi.de
Fri Jun 10 08:05:24 UTC 2022

Hi Karl --

Is moving around menus such a frequent use case? We have no fast check (e.g., #isMenuMorph) like we have via #isSystemWindow. And I would rather not have an #isKindOf: check here. We should tackle this issue again after the release. Maybe open an issue on GitHub via bugs.squeak.org? :-)

Am 09.06.2022 19:42:31 schrieb karl ramberg <karlramberg at gmail.com>:
If we exclude MenuMorphs as well here we cover most use cases :-)


On Thu, Jun 9, 2022 at 11:22 AM <commits at source.squeak.org [mailto:commits at source.squeak.org]> wrote:

Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.2004.mcz [http://source.squeak.org/trunk/Morphic-mt.2004.mcz]

==================== Summary ====================

Name: Morphic-mt.2004
Author: mt
Time: 9 June 2022, 11:22:18.32773 am
UUID: aa7a84f1-7b05-414a-a3e7-107333694eff
Ancestors: Morphic-mt.2003

Fixes regression in prior commit with "fast-window-drag" enabled.

=============== Diff against Morphic-mt.2003 ===============

Item was changed:
  ----- Method: SystemWindow>>mouseEnterDragging: (in category 'events') -----
  mouseEnterDragging: evt
        "unlock children for drop operations"

        self flag: #performance. "mt: There may be no need to change appearance if no widget wants the drop. As a trade-off, we avoid expensive visual updates if the user drags a system window and window-embedding in nested world morphs is not allowed."
+       (evt hand hasSubmorphs
+               and: [evt hand firstSubmorph isSystemWindow]
-       (evt hand firstSubmorph isSystemWindow
                and: [Preferences systemWindowEmbedOK not])
                        ifTrue: [^ self].

        self isActive ifTrue: [self lookFocused].

        (self isActive not and: [evt hand hasSubmorphs]) ifTrue: [
                self activate. "unlock contents for drop"
                evt hand addMouseListener: self. "for drop completion on submorph"

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220610/2888961f/attachment.html>

More information about the Squeak-dev mailing list