[squeak-dev] Re-signalling an already signaled exception
christoph.thiede at student.hpi.uni-potsdam.de
christoph.thiede at student.hpi.uni-potsdam.de
Fri Jun 10 11:30:00 UTC 2022
Hi Jaromir,
Thanks for working on this! I'm possibly a bit late on the party, but I noticed that current #signal only keeps the messageText, not any other custom properties of an exception. I'm not sure whether this is the expected behavior. :)
Think of this revised example:
[(KeyNotFound key: #plonk) signal] on: Error do: [:ex |
[ex signal] on: KeyNotFound do: [:ex2 | Transcript show: ex2]]
It will print out "Key not found: nil" to the Transcript, instead of printing the original key.
Without diving deeper into this discussion, my first impression would have been that some kind of #freshCopy (maybe with a better name?) would be a more holistic approach to honor any state in subclasses of Exception. What do you think? :-)
Best,
Christoph
---
Sent from Squeak Inbox Talk
On 2022-02-06T11:42:46+01:00, mail at jaromir.net wrote:
> Hi,
> just an update: I've sent a proposal to the Inbox: Kernel-jar.1446 with the following code:
>
> signal
> "Ask ContextHandlers in the sender chain to handle this signal. The default is to execute and return my defaultAction.
> Sending #signal to an already signaled exception generates a new exception of the same type with the same messageText"
>
> signalContext ifNotNil: [^self class signal: messageText].
> signalContext := thisContext contextTag.
> ^(thisContext nextHandlerContextForSignal: self) handleSignal: self
>
> If possible I'd like to withdraw my previous contribution to #signal making repeated #signal sends equivalent to sending #outer, to prevent future code from using that misleading approach. Subsequent #signal sends are NOT equivalent to #outer and they have their own subtly different meaning discussed here - provided my interpretation of ANSI is right this time :)
>
> Thanks for your time and apologies for previous confusion.
>
> best,
> Jaromir
> ^[^
> --
> Sent from Squeak Inbox Talk
>
> On 2022-02-05T18:48:39+01:00, mail at jaromir.net wrote:
>
> > Hi Chris,
> >
> > On 2022-02-04T17:11:35-06:00, asqueaker at gmail.com wrote:
> >
> > > Hi Jaromir,
> > >
> > > Here's a motivation example:
> > > >
> > > > [1/0] on: Error do: [:ex |
> > > > [ex signal] on: ZeroDivide do: [Transcript show: #ZeroDivide]
> > > > ]
> > > >
> > > > Would you expect this code to work and pick up the ZeroDivide handler?
> > > >
> > > ...
> > >
> > > > The point or a use case is to provide additional (finer, more specific)
> > > > handlers inside the general handler rather than wrap the general handler
> > > > inside more specific handlers. More specific handlers can even be inside a
> > > > method so the readability would not degrade.
> > > >
> > >
> > > I was able to do it by creating a new exception instance and signaling it:
> > >
> > > [1/0] on: Error do: [: err |
> > > [err copy signal] on: ZeroDivide do: [Transcript show:
> > > #ZeroDivide] ]
> > >
> > > I don't know about #copy, though, you might want to implement your own
> > > special #freshCopy that throws out the signalContext, handlerContext and
> > > outerContext, but the above "worked". :)
> > >
> >
> > Precisely, it crossed my mind too and yes, it has to be a "fresh" copy with blank instance variables (except messageText). A simple copy fails tests with nested outer etc...
> >
> > I've checked ANSI again and they say, quote: [5.5.3.1 messageText][...] Subsequent sends of of the message #messageText to a signaled exception generated by sending the message #signal to the receiver of this message [note: the receiver is an exception instance] will also return this value.
> >
> > So what I'm actually looking for is this: (and it's equivalent to the "fresh" copy idea)
> >
> > [1/0] on: Error do: [: err |
> > [err class signal: err messageText] on: ZeroDivide do: [Transcript show: #ZeroDivide] ]
> >
> > If I'm interpreting ANSI's intention correctly then we could update our #signal like this:
> >
> > signal
> > "Ask ContextHandlers in the sender chain to handle this signal. The default is to execute and return my defaultAction.
> > Signaling an already signaled exception is interpreted as signaling a new exception of the same type with the same messageText"
> >
> > - signalContext ifNotNil: [^self outer].
> > + signalContext ifNotNil: [^self copy signal: self messageText].
> > signalContext := thisContext contextTag.
> > ^(thisContext nextHandlerContextForSignal: self) handleSignal: self
> >
> > It was my idea last year to make subsequent sends of #signal to an already signaled exception equivalent to #outer and now I can see it was wrong and I'd like to really fix it this time :) All test are green, even the ones in Tests-jar.464.
> >
> > Thanks, Chris, for discussing this.
> >
> > best,
> > Jaromir
> > ^[^
> > --
> > Sent from Squeak Inbox Talk
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220610/00077a66/attachment.html>
More information about the Squeak-dev
mailing list
|