[squeak-dev] The Inbox: TrueType-ct.95.mcz

Thiede, Christoph Christoph.Thiede at student.hpi.uni-potsdam.de
Fri Jun 17 09:48:31 UTC 2022

Thanks for the clarification! Can I merge this? :-)



Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Freitag, 17. Juni 2022 10:20:25
An: squeak-dev at lists.squeakfoundation.org
Betreff: Re: [squeak-dev] The Inbox: TrueType-ct.95.mcz

We do not want to have that because of the domain. Multiple fonts can be in a single file, and often multiple files describe a single font. Better communicate that to the programmer to avoid surprises. That's why the answer should always be an array, too.

From: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> on behalf of commits at source.squeak.org <commits at source.squeak.org>
Sent: Thursday, June 16, 2022 5:32:13 PM
To: squeak-dev at lists.squeakfoundation.org <squeak-dev at lists.squeakfoundation.org>
Subject: [squeak-dev] The Inbox: TrueType-ct.95.mcz

A new version of TrueType was added to project The Inbox:

==================== Summary ====================

Name: TrueType-ct.95
Author: ct
Time: 16 June 2022, 5:32:12.262112 pm
UUID: 447342b6-162a-4948-a847-ba2ba3fdb5c0
Ancestors: TrueType-mt.94

Fixes senders of deprecated TTCFontSet class >> #newTextStyleFromTTFile:. Complements TrueType-mt.94. Please review. Do we really do not want to have #installFromFileName: (singular selector)?

=============== Diff against TrueType-mt.94 ===============

Item was changed:
  ----- Method: HostFont class>>initForSubtitles (in category '*TrueType') -----
         HostFont initForSubtitles

         HostFont textStyleFrom: 'Verdana' sizes: #(18 20 22 24 26 28) ranges: HostFont defaultRanges.

         StrikeFontSet installExternalFontFileName: 'greekFont.out' encoding: GreekEnvironment leadingChar encodingName: #Greek textStyleName: #DefaultMultiStyle.

         TTCFontReader encodingTag: SimplifiedChineseEnvironment leadingChar.
+        TTCFontSet installFromFileNames: {'C:\WINDOWS\Fonts\simhei.TTF'}.
-        TTCFontSet newTextStyleFromTTFile: 'C:\WINDOWS\Fonts\simhei.TTF'.

         TTCFontReader encodingTag: JapaneseEnvironment leadingChar.
+        TTCFontSet installFromFileNames: {'C:\WINDOWS\Fonts\msgothic.TTC'}.
-        TTCFontSet newTextStyleFromTTFile: 'C:\WINDOWS\Fonts\msgothic.TTC'.

         TTCFontReader encodingTag: KoreanEnvironment leadingChar.
+        TTCFontSet installFromFileNames: {'C:\WINDOWS\Fonts\gulim.TTC'}.!
-        TTCFontSet newTextStyleFromTTFile: 'C:\WINDOWS\Fonts\gulim.TTC'.
- !

Item was changed:
  ----- Method: TTCFont class>>serviceInstallTrueTypeFontStyle (in category 'file list services') -----
         "Return a service to install a true type font as a text style"

+        ^ (SimpleServiceEntry
-        ^ SimpleServiceEntry
                 provider: self
                 label: 'install TrueType font'
+                selector: #installFromFileNames:
-                selector: #newTextStyleFromTTFile:
                 description: 'install a TrueType font as a new text style'
+                buttonLabel: 'install ttf')
+                argumentGetter: [:fileName | {fileName fullName}]!
-                buttonLabel: 'install ttf'!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220617/e6a256ef/attachment.html>

More information about the Squeak-dev mailing list