[squeak-dev] #setAuthorInitials inconsistent behavior

Jaromir Matas mail at jaromir.net
Mon Jun 20 08:33:09 UTC 2022


Hi Marcel,

Thanks for your explanation.

> One possible change -- that needs to be discussed after the release -- would be to answer something like "unknown" if the user cancels the dialog.

My opinion: I like the way it is that you MUST enter some initials otherwise the changes won’t be saved. I just thought cancelling the dialogue while NOT saving method changes would achieve the same result, i.e. no unauthored method changes.

Anyway; thanks again, shall I close the github issue?
Best,
jaromir


--

Jaromír Matas

mail at jaromir.net

From: Marcel Taeumel<mailto:marcel.taeumel at hpi.de>
Sent: Monday, June 20, 2022 10:14
To: squeak-dev<mailto:squeak-dev at lists.squeakfoundation.org>
Subject: Re: [squeak-dev] #setAuthorInitials inconsistent behavior

Hi Jaromir --

> Is this intentional?

Yes. The manual way to set author initials can easily be canceled. However, there are some places that rely on some initials to be set. So, calling #authorInitials will loop until until the user enters something. If you want to cancel those situations, you have to do, for example, CMD+Dot because you would also cancel any control flow that needs those credentials.

One possible change -- that needs to be discussed after the release -- would be to answer something like "unknown" if the user cancels the dialog. Yet, I would argue that that dialog MUST pop up again during the next request for #authorInitials.

Best,
Marcel

Am 18.06.2022 15:17:35 schrieb Jaromir Matas <mail at jaromir.net>:
Hi all,

Two scenarios in a fresh image without author initials previously set:

A) invoke Extras -> Set author initials dialogue
   -> Now hit cancel and the dialogue disappears

B) make a change in a method and try to save -> Save author initials dialogue appears
   -> Now hit cancel and the dialogue reappears and it's impossible to get rid of it...
   ... unless you chose `debug invocation` from the dialogue window menu and close the debugger

Is this intentional? I'd expect the dialogue to disappear and method changes remain unsaved. Opened an issue on github.

Best,

--

Jaromír Matas

mail at jaromir.net


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220620/0737a402/attachment-0001.html>


More information about the Squeak-dev mailing list