I removed it from the inbox

Best,
Karl

On Mon, Jun 20, 2022 at 1:27 PM Marcel Taeumel <marcel.taeumel at hpi.de>
wrote:

> Hi Karl --
>
> > The whole image stops when you are holding down the mouse button on a
> text link. So there is room for improvement
>
> Exactly. There are more symptoms of this issue. Yet, it is not advisable
> to degrade the implementation quality of TextAction when the strange code
> actually sits in TextEditor/NewParagraph.
>
> Best,
> Marcel
>
> Am 20.06.2022 13:05:00 schrieb karl ramberg <karlramberg at gmail.com>:
>
>
> On Mon, Jun 20, 2022 at 11:39 AM Marcel Taeumel <marcel.taeumel at hpi.de>
> wrote:
>
>> Hi Karl --
>>
>> Take a look at the following places to better understand, why we must not
>> use #addDeferredUIMessage: in #actOnClickFor:
>>
>> TextMorph >> #mouseDown:
>> TextEditor >> #mouseDown:
>> NewParagraph >> #clickAt:for:controller:
>>
>> The expected control flow in the #mouseDown: handler is synchronous.
>> Hmm... I recall a similar issue with #mouseDown: vs. #mouseUp: when
>> implementing other buttons.
>>
>> Usually, the reaction should be in #mouseUp:. In TextAction, the
>> effective reaction is currently in the #mouseDown: handler of TextMorph
>> even if TextEditor waits for this MVC-style mouse-up event in a loop. Hmm...
>>
>
> The whole image stops when you are holding down the mouse button on a text
> link. So there is room for improvement
> Best,
> Karl
>
>
>> Best,
>> Marcel
>>
>> Am 17.06.2022 10:23:31 schrieb Taeumel, Marcel <marcel.taeumel at hpi.de>:
>> -1 bc. wrong place. See senders of actOnClickFor: and my other answer.
>> Let's work on that (bigger) issue after the release.
>>
>> Best,
>> Marcel
>> ------------------------------
>> *From:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> on
>> behalf of commits at source.squeak.org <commits at source.squeak.org>
>> *Sent:* Thursday, June 16, 2022 9:59:32 PM
>> *To:* squeak-dev at lists.squeakfoundation.org <
>> squeak-dev at lists.squeakfoundation.org>
>> *Subject:* [squeak-dev] The Inbox: Collections-kfr.1012.mcz
>>
>> A new version of Collections was added to project The Inbox:
>> http://source.squeak.org/inbox/Collections-kfr.1012.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-kfr.1012
>> Author: kfr
>> Time: 16 June 2022, 9:59:32.00337 pm
>> UUID: 52865d2e-6f39-f14f-8c48-b630ecfd76a5
>> Ancestors: Collections-lrnp.1011
>>
>> TextLinks would sometimes open i the background
>>
>> =============== Diff against Collections-lrnp.1011 ===============
>>
>> Item was changed:
>>   ----- Method: TextLink>>actOnClickFor: (in category 'event handling')
>> -----
>>   actOnClickFor: aMessageSet
>>          "Add to the end of the list.  'aClass selector', 'aClass
>> Comment', 'aClass Definition', 'aClass Hierarchy' are the formats allowed."
>>
>> +        Project current addDeferredUIMessage: [aMessageSet addItem:
>> classAndMethod].
>> -        aMessageSet addItem: classAndMethod.
>>          ^ true!
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220620/d9008d6b/attachment.html>