[squeak-dev] The Trunk: Tools-tpr.1008.mcz
marcel.taeumel at hpi.de
Wed Jun 22 17:52:25 UTC 2022
Hi Tim --
Yeah, we can do better. Of course. The actual problem is the established contract of an interface. Actually, I would like to revert your changes after the release. However, due to the timeliness, I found it better to quickly do that check to fix the issue that we found, which was the "Method Inheritance" tool. :-)
A MessageSet did never behave like a Set. It had order and relied on the client to remove the duplicates. Changing that breaks compatibility.
Anyway, it works for now.
Am 22.06.2022 19:24:14 schrieb tim Rowledge <tim at rowledge.org>:
Yeah, I was just looking into what that change was all about - plenty long ago enough to be a mystery. My notes suggest it was fixing duplications in the incoming list and so using a Set was pretty obvious. I'm astonished it's taken almost 2 years for anyone to notice any problem...
I think the real problem here is trying to use a simple listing UI to present too-sophisticated information. A message trace browser could probably do much better with something akin to a folding-list UI. Or even a cool!Graphical!web! (like https://vega.github.io/vega/examples/edge-bundling/ or similar)
Lots of work though. But then all the browsers are pretty naff when you look at the structures; subclassing from StringHolder? Really?
> On 2022-06-22, at 12:03 AM, Marcel Taeumel wrote:
> Hi Tim --
> This introduced a regression, which I now fixed via Tools-mt.1165.
> Yes, the name "MessageSet" indicates a Set semantic. However, tools in the past have relied on the sort order. We must preserve that. I added a simple "Does it have indentation?" test to assume pre-defined sort order.
... and having to use that sort of test it why we really should do better with the broader structure. But still, we can't solve that at this stage.
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
He who hesitates is probably right.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev