Thanks for maintaining compatibility with TruffleSqueak, Christoph! :)

-- Fabio


On Tue, Apr 26, 2022 at 3:57 PM Thiede, Christoph <
Christoph.Thiede at student.hpi.uni-potsdam.de> wrote:

> Hi Marcel,
>
>
> thank you! In doubt, I would always use #allSubInstancesDo: instead of
> #allInstancesDo: for the same reason we (almost) always use #isKindOf:
> rather than #isMemberOf: - because any subclass might just be an
> implementation detail of the original protocol. I think this is an amount
> of speculative generality that does not hurt. :-) There are indeed some
> subclasses of Workspace (e.g., I think TruffleSqueak does this), and by
> default, their styling should just work like in any normal workspace.
>
>
> Best,
>
> Christoph
> ------------------------------
> *Von:* Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im
> Auftrag von Taeumel, Marcel
> *Gesendet:* Dienstag, 26. April 2022 13:52:15
> *An:* squeak-dev
> *Betreff:* Re: [squeak-dev] The Inbox: Tools-ct.1147.mcz
>
> Hi Christoph --
>
> There are no subclasses of Workspace. I am not sure whether we even want
> to encourage to have some. At least not in this way. Hmm...
> #allInstancesDo: should be sufficient for this purpose.
>
> Anyway: +1 :)
>
> Best,
> Marcel
>
>
> Am 26.04.2022 12:12:48 schrieb commits at source.squeak.org <
> commits at source.squeak.org>:
> A new version of Tools was added to project The Inbox:
> http://source.squeak.org/inbox/Tools-ct.1147.mcz
>
> ==================== Summary ====================
>
> Name: Tools-ct.1147
> Author: ct
> Time: 26 April 2022, 12:12:36.942702 pm
> UUID: 11944f29-f575-7b41-824d-71e945afa0d2
> Ancestors: Tools-tpr.1146
>
> Updates workspace styles after toggling #shouldStyle preference. This also
> improves the liveness in the preference wizard.
>
> =============== Diff against Tools-tpr.1146 ===============
>
> Item was changed:
> ----- Method: Workspace class>>shouldStyle: (in category 'preferences')
> -----
> shouldStyle: aBoolean
>
> + ShouldStyle := aBoolean.
> +
> + self allSubInstancesDo: [:workspace | workspace changed: #style].!
> - ShouldStyle := aBoolean!
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220624/8ae2dd38/attachment.html>