[squeak-dev] The Inbox: Tools-kfr.1167.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Jun 26 06:36:12 UTC 2022


A new version of Tools was added to project The Inbox:
http://source.squeak.org/inbox/Tools-kfr.1167.mcz

==================== Summary ====================

Name: Tools-kfr.1167
Author: kfr
Time: 26 June 2022, 8:36:06.371744 am
UUID: c1c757da-7378-8a4c-b8e8-4b72872011ce
Ancestors: Tools-mt.1166

When inspecting forms of depth 2, 4 and 8 you get issues with displaying them on a 32 bit depth display.
You get a black rectangle or wrong colors.

This change converts the form to the same depth as the display so it will display correctly.

Technically by converting the form to display depth you are changing what you are inspecting so I'm not sure if this is the correct thing to do. That depends on what the intentions of the pixels selection in the inspector has. Is it for just displaying or for further manipulation?

=============== Diff against Tools-mt.1166 ===============

Item was changed:
  ----- Method: FormInspector>>fieldPixels (in category 'fields') -----
  fieldPixels
  
  	^ (self newFieldForType: #misc key: #pixels)
  		name: 'pixels' translated; emphasizeName;
  		printValueAsIs;
+ 		valueGetter: [:form | self embedForm: (form asFormOfDepth: Display depth) inText: form printString];
- 		valueGetter: [:form | self embedForm: form inText: form printString];
  		yourself!



More information about the Squeak-dev mailing list