Hi Marcel,


sorry, then instead of commenting it out, let's change it to "softLineWrap: true".


> Here, it is explicit that we do not want soft line breaks.


Why exactly not? What is the advantage of inserting manual line breaks in all example texts? I don't understand. :-)


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 28. März 2022 18:55:28
An: squeak-dev
Betreff: Re: [squeak-dev] The Trunk: Collections-ct.998.mcz

Hi Christoph --

You know that it makes sense to document the expected defaults in case those change at some point? Here, it is explicit that we do not want soft line breaks. It is similar to when somebody sets the color of a morph to its default blue. ;-) (... and here in case somebody replaces #pluggableTextPaneSpec with #pluggableCodePaneSpec ...)

Please don't start removing init-code that happens to match the current defaults. For example, you will find "hResizing: #rigid" at several places...

Best,
Marcel

Am 28.03.2022 17:46:26 schrieb christoph.thiede at student.hpi.uni-potsdam.de <christoph.thiede at student.hpi.uni-potsdam.de>:

Hi Marcel,

sorry, I missed that. Hm ... Why do we need that #softLineWrap: in FontImporterTool>>#buildPreviewPaneWith:? If I comment out this line, all preview texts look plausible to me. But maybe I am missing something else. :-)

Best,
Christoph

---
Sent from Squeak Inbox Talk<https://github.com/hpi-swa-lab/squeak-inbox-talk>

On 2022-03-28T16:38:50+02:00, marcel.taeumel at hpi.de wrote:

> Hi Christoph --
>
> > Removes obsolete line breaks from the comment.
>
> Please re-add those line breaks ASAP. This is no dialog text but exemplary filler text. This must be layouted for now. See Font Importer -> Source Code as an example.
>
> Thanks. :-)
>
>
> Best,
> Marcel
> Am 28.03.2022 13:57:29 schrieb commits at source.squeak.org <commits at source.squeak.org>:
> Christoph Thiede uploaded a new version of Collections to project The Trunk:
> http://source.squeak.org/trunk/Collections-ct.998.mcz
>
> ==================== Summary ====================
>
> Name: Collections-ct.998
> Author: ct
> Time: 28 March 2022, 1:56:52.242267 pm
> UUID: 74080f41-16ed-dc43-8f7c-1cd16bc91db7
> Ancestors: Collections-ct.997
>
> Adds literal arrays and scaled decimals to the smalltalk postcard. Removes obsolete line breaks from the comment.
>
> =============== Diff against Collections-ct.997 ===============
>
> Item was changed:
> ----- Method: Text class>>codeSample (in category 'filler text') -----
> codeSample
>
> ^ 'exampleWithNumber: x
> + "A method that illustrates every part of Smalltalk method syntax including primitives. It has unary, binary, and keyboard messages; declares arguments and temporaries; accesses a global variable (but not an instance variable); uses literals (array, nested array, character, symbol, string, integer, float, scaled decimal, and byte array); uses the pseudo variables nil, true, false, self, super, and thisContext; shows that within a literal array nil, true, and false are symbols not pseudo variables; and has sequence, assignment, return, cascade, and tuple (array) creation. It has both zero argument and one argument blocks, and has a block temporary."
> - "A method that illustrates every part of Smalltalk method syntax
> - including primitives. It has unary, binary, and keyboard messages,
> - declares arguments and temporaries, accesses a global variable
> - (but not an instance variable), uses literals (array, character, symbol,
> - string, integer, float, byte array), uses the pseudo variables nil, true,
> - false, self, super, and thisContext, shows that within a literal array
> - nil, true and false are symbols not pseudo variables, and has sequence,
> - assignment, return, cascade, and tuple (array) creation. It has both
> - zero argument and one argument blocks, and has a block temporary."
>
> | y |
> true & false not & (nil isNil) ifFalse: [self halt].
> y := self size + super size.
> + #($a #a ''a'' "a" (1 1.0 1.0s2) nil true false), { #[65]. thisContext. nil. true. false }
> - #($a #a ''a'' "a" 1 1.0 nil true false), { #[65]. thisContext. nil. true. false }
> do: [ :each | | class |
> class := each class.
> Transcript
> show: (class name);
> show: '' ''].
> ^ x
>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220328/27278fe8/attachment.html>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20220328/60e8b2c1/attachment.html>